Executable Merkle proofs #1363
Merged
Executable Merkle proofs #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
commented
Aug 15, 2019
hwwhww
commented
Aug 15, 2019
vbuterin
reviewed
Aug 17, 2019
vbuterin
reviewed
Aug 17, 2019
hwwhww
force-pushed
the
executable_merkle_proofs
branch
from
a1061f0
to
d6bbd9b
Compare
vbuterin
reviewed
Aug 23, 2019
specs/light_client/merkle_proofs.md
Outdated
| We define the following Python custom types for type hinting and readability: | ||
|
|
||
| | - | - | - | | ||
| | `GeneralizedIndex` | `uint64` | the index of a node in a binary Merkle tree | |
There was a problem hiding this comment.
A GeneralizedIndex is NOT necessarily a uint64. It could be bigger. My idea was to represent it in the python executable as a bigint, but then clarify that representing it as a bitfield/bitlist is ok too.
hwwhww
force-pushed
the
executable_merkle_proofs
branch
from
8c3f315
to
bbaa238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#1323 needs some shared logic in
specs/light_client/merkle_proofs.md. And also, we can use the helper functions inmerkle_proofs.mdto generate the test cases for #1323.Description
This PR is making
merkle_proofs.mdexecutable.TODOs: