Vyper b13 -> b13.hotfix1761 [replacement] #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @daejunpark |
daejunpark
approved these changes
Dec 19, 2019
protolambda
approved these changes
Dec 19, 2019
There was a problem hiding this comment.
Not too happy with sticking to a "hotfix" release, but otherwise it looks ok. The introduction of "gas" opcode there in that vyper PR may have future backwards-compatible concerns if the opcode itself changes (E.g. see Wei Tang devcon5 talk). But in status quo of evm it improves things by not hardcoding it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #1536. Fixes the way the custom release is added to
requirements.txtand bumps circleci deposit cache to ensure re-builds properlyRelease made to
dev. To be released with BLS inv0.10.0Original comment
Update to Vyper hotfix release, as suggested in vyperlang/vyper#1771 (comment)