Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dark-mode-friendly images #1010

Closed
samajammin opened this issue May 6, 2020 · 3 comments
Closed

Add dark-mode-friendly images #1010

samajammin opened this issue May 6, 2020 · 3 comments
Labels
design required 🎨 This involves design changes feature ✨ This is enhancing something existing or creating something new

Comments

@samajammin
Copy link
Contributor

Is your feature request related to a problem? Please describe.

/build page images don't look nice on dark mode:
Image 2020-05-06 at 12 12 05 PM

Describe the solution you'd like

Let's get images...
A) w/ transparent backgrounds
B) for each light mode & dark mode that we can swap out (like on /foundation page)

Describe alternatives you've considered

None

Additional context

None
@samajammin samajammin added feature ✨ This is enhancing something existing or creating something new design required 🎨 This involves design changes labels May 6, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2020

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jun 6, 2020
@samajammin samajammin removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jun 8, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2020

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 9, 2020
@samajammin
Copy link
Contributor Author

@ryancreatescopy can you think of any quick-hit solutions for this?

@samajammin samajammin removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 11, 2020
samajammin pushed a commit that referenced this issue Jul 24, 2020
@samajammin
Fixing #1010
a77313c
@ryancreatescopy ryancreatescopy mentioned this issue Jul 24, 2020
Merged
@samajammin samajammin mentioned this issue Jul 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design required 🎨 This involves design changes feature ✨ This is enhancing something existing or creating something new
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samajammin