Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H4 sizing on /staking page #11409

Closed
1 of 2 tasks
wackerow opened this issue Oct 10, 2023 · 10 comments · Fixed by #11772
Closed
1 of 2 tasks

H4 sizing on /staking page #11409

wackerow opened this issue Oct 10, 2023 · 10 comments · Fixed by #11772
Assignees
Labels
bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing needs triage 📥 This issue needs triaged before being worked on

Comments

@wackerow
Copy link
Member

Describe the bug

H4's on /staking pages appear to have grown in size to 36px from 20px.

To reproduce

  1. Go to https://ethereum.org/en/staking/#comparison-of-options
  2. See size of H4's

Expected behavior

This is what is was previously like (and would expect):

image

Screenshots

Currently:

image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

@nloureiro or @konopkja if you could confirm this

Would you like to work on this issue?

  • Yes
  • No
@wackerow wackerow added the bug 🐛 Something isn't working label Oct 10, 2023
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Oct 10, 2023
@wackerow wackerow added good first issue Good item to try if you're new to contributing and removed needs triage 📥 This issue needs triaged before being worked on labels Oct 10, 2023
@nloureiro
Copy link
Contributor

yes, something broke here.

this a green shot of the old Figma file
Screen Shot 2023-10-10 05 59 04 PM

I would say to remove all the font-sizes here a let the design system default H4 style kick in.

Screen Shot 2023-10-10 06 05 45 PM

@theavitw
Copy link

I can do this.

@Another-DevX
Copy link

i'm working on this

@suhani1804
Copy link

can you assign me?

@shubhusion
Copy link

shubhusion commented Nov 2, 2023

Kindly assign this issue to me.

@konopkja
Copy link
Contributor

konopkja commented Nov 3, 2023

i can confirm h4 is supposed to be 20px
Screenshot 2023-11-03 at 9 40 02

@shyam-patel-kira
Copy link
Contributor

shyam-patel-kira commented Dec 7, 2023

Hi @konopkja, seems like the bug was introduced when all HTML headings were migrated to use chakraHeading instead. Please assign this issue to me.

shyam-patel-kira added a commit to shyam-patel-kira/ethereum-org-website that referenced this issue Dec 7, 2023
@Nash0509
Copy link

Nash0509 commented Jan 2, 2024

@konopkja the core issue is because of the Chakra-heading class that is being used. So I think we should modify those H4 in order to not disturb the other bigger picture. Consider assigning it to me...

@shyam-patel-kira
Copy link
Contributor

@Nash0509, I've already implemented a fix for this issue here.

@nloureiro
Copy link
Contributor

The PR fixes this > #11772 (review)

The H4 looks good. Thank you!

@nhsz nhsz reopened this Feb 16, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Feb 16, 2024
nhsz added a commit that referenced this issue Feb 16, 2024
This was referenced Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing needs triage 📥 This issue needs triaged before being worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants