Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update USDC link on stablecoin.tsx #12077

Closed
1 of 2 tasks
barskhianfannie opened this issue Jan 31, 2024 · 5 comments
Closed
1 of 2 tasks

Update USDC link on stablecoin.tsx #12077

barskhianfannie opened this issue Jan 31, 2024 · 5 comments
Labels
bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing

Comments

@barskhianfannie
Copy link
Contributor

barskhianfannie commented Jan 31, 2024

Describe the bug

On the stablecoins.tsx page, there is a link which should lead users to the Native USDC Token Page on Matcha. This link is incorrect and routing users to a 404 page on matcha.

The link which is defined here should be updated to - https://matcha.xyz/tokens/ethereum/0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48

To reproduce

  1. Go to Stablecoins page on ethereum.org
  2. Click on 'Swap Eth for USDC as shown in the screenshot below.
  3. Notice this routes you to a 404 page.
    Screen Shot 2024-01-31 at 11 33 50 AM

Expected behavior

This link should instead be updated to the appropriate Native USDC Token Page on Matcha.

Code Line to be updated -

to="https://matcha.xyz/markets/ETH/USDC"

Would you like to work on this issue?

  • Yes
  • No
@barskhianfannie barskhianfannie added the bug 🐛 Something isn't working label Jan 31, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jan 31, 2024
@corwintines corwintines added good first issue Good item to try if you're new to contributing and removed needs triage 📥 This issue needs triaged before being worked on labels Feb 1, 2024
@corwintines
Copy link
Member

Agree with getting this link updated. No strong feelings of if its matcha, or uniswap. Something with a large sized dex.

@ethereum ethereum deleted a comment Feb 1, 2024
@rachana-uniyal
Copy link

Hi, can I work on this issue?

Molotov-Eugene added a commit to Molotov-Eugene/ethereum-org-website that referenced this issue Feb 2, 2024
@a-hagi613
Copy link
Contributor

is this issue resolved? if not i can take it

@Nagu40
Copy link

Nagu40 commented Feb 8, 2024

<ButtonLink
mb={4}
me={4}
to="https://matcha.xyz/tokens/ethereum/0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48"

{t("page-stablecoins-usdc-banner-swap-button")}

minimalsm added a commit that referenced this issue Feb 12, 2024
fixed the broken link to correct one stated in issue: Update USDC link on stablecoin.tsx #12077
@minimalsm
Copy link
Contributor

Closed by #12112

This was referenced Feb 14, 2024
This was referenced Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing
Projects
None yet
Development

No branches or pull requests

7 participants
@corwintines @barskhianfannie @rachana-uniyal @minimalsm @a-hagi613 @Nagu40 and others