Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: missing space in history entries #12101

Closed
1 of 2 tasks
wackerow opened this issue Feb 2, 2024 · 6 comments
Closed
1 of 2 tasks

Bug: missing space in history entries #12101

wackerow opened this issue Feb 2, 2024 · 6 comments
Assignees
Labels
bug 🐛 Something isn't working dev required This requires developer resources good first issue Good item to try if you're new to contributing

Comments

@wackerow
Copy link
Member

wackerow commented Feb 2, 2024

Describe the bug

We're missing a space before the block/epoch/slot values for each entry on the /history page.

To reproduce

  1. Go to https://ethereum.org/history
  2. See any upgrade entry where it displays either "Epoch number", "Slot number" and/or "Block number"; notice the lack of a space between this label and the value being shown.

Expected behavior

Should have a single space rendered between the label and value.

Screenshots

image

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional context

Culprit is likely inside the NetworkUpgradeSummary component (/src/components/History/NetworkUpgradeSummary.tsx), in the blockTypeTranslation function.

There does seem to be a {" "} in there, and an up-close screenshot of the text selected...

image

...reveals that the space appears to be present, but for some reason it's collapsing so it doesn't actually take up space.

Would you like to work on this issue?

  • Yes
  • No
@wackerow wackerow added the bug 🐛 Something isn't working label Feb 2, 2024
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Feb 2, 2024
@wackerow wackerow added good first issue Good item to try if you're new to contributing dev required This requires developer resources and removed needs triage 📥 This issue needs triaged before being worked on labels Feb 2, 2024
@yash251
Copy link
Contributor

yash251 commented Feb 2, 2024

hello ser, please assign me this issue

@a-hagi613
Copy link
Contributor

has this been resolved?

@mabsattar
Copy link

Hi, I would like to work on this, can you assign me.

@kaksv
Copy link

kaksv commented Feb 6, 2024

I have ended up reading the entire history. Its so interesting. 🥳

@kaksv
Copy link

kaksv commented Feb 6, 2024

When I check the document in markdown format, I realize that the data we are meant to edit initally is a component and I am requesting to know the exact location of the component.

@Nagu40
Copy link

Nagu40 commented Feb 8, 2024

const blockTypeTranslation = (translationKey, explorerUrl, number) => {
return (


{t(translationKey)}: {" "} {/* Added space here */}
<InlineLink to={${explorerUrl}${number}}>
{new Intl.NumberFormat(localeForStatsBoxNumbers).format(number)}


)
}

@corwintines corwintines self-assigned this Feb 12, 2024
corwintines added a commit that referenced this issue Feb 12, 2024
This was referenced Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working dev required This requires developer resources good first issue Good item to try if you're new to contributing
Projects
None yet
Development

No branches or pull requests

7 participants