Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated URL scheme produces broken links #1297

Closed
wolovim opened this issue Aug 3, 2020 · 3 comments
Closed

Updated URL scheme produces broken links #1297

wolovim opened this issue Aug 3, 2020 · 3 comments
Assignees
Labels
bug 馃悰 Something isn't working high priority This has a high priority

Comments

@wolovim
Copy link
Member

wolovim commented Aug 3, 2020

Describe the bug
Hey team 馃憢. In our (web3.py) documentation, we include a link to the python resources, formally located at ethereum.org/python, which now throws a 404. Manual navigation makes clear that this route has updated to ethereum.org/en/python. Was the intention to remove a "default" English route?

Expected behavior
By making this update, I have to imagine that very many Ethereum.org links around the web are now broken. My expectation would be for English to be the default. If not a working URL, at least a redirect to the /en/ namespace would be preferable.

馃嵒

@wolovim wolovim added the bug 馃悰 Something isn't working label Aug 3, 2020
@samajammin samajammin added the high priority This has a high priority label Aug 12, 2020
@samajammin
Copy link
Contributor

samajammin commented Aug 12, 2020

Yikes! Thanks for the report @marcgarreau! I added redirects from the old URLs but looks like I missed those language pages. Fixing now.

@samajammin
Copy link
Contributor

@all-contributors please add @marcgarreau for bugs

@allcontributors
Copy link
Contributor

@samajammin

I've put up a pull request to add @marcgarreau! 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 馃悰 Something isn't working high priority This has a high priority
Projects
None yet
Development

No branches or pull requests

2 participants