Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero image sits under navigation #1299

Closed
ryancreatescopy opened this issue Aug 7, 2020 · 0 comments
Closed

Hero image sits under navigation #1299

ryancreatescopy opened this issue Aug 7, 2020 · 0 comments
Labels
bug 🐛 Something isn't working low priority This has a low priority

Comments

@ryancreatescopy
Copy link
Contributor

ryancreatescopy commented Aug 7, 2020

Describe the bug

On the homepage, the navigation bar should be above the hero image, not sitting on top of it. At the moment, the nav bar sits on top of the image meaning the focus of the image feels squashed towards the top. This isn't a major bug because it doesn't cut off any of the image, but if we were to swap images in the future to something with detail at the top of the image it runs the risk of being cut off.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'ethereum.org'

Expected behavior

The nav bar should be above the image in hierarchy and not just sit on top of it.

Screenshots

image

image

@ryancreatescopy ryancreatescopy added bug 🐛 Something isn't working low priority This has a low priority labels Aug 7, 2020
samajammin added a commit that referenced this issue Aug 12, 2020
Prevent Nav overlap on Page [Fixes #1299]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working low priority This has a low priority
Projects
None yet
Development

No branches or pull requests

1 participant