-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fallback redirects for requests that don't include a language path #1374
Comments
@ryancreatescopy curious to hear your thoughts on this - is site search an adequate solution? Or would some additional copy be helpful here? |
I think content is a bit of a band-aid to this problem but it couldn't hurt to add a suggestion here to check the language path (providing we think the user knows what their language path is). Ideally, I'd like us to pursue the automatic redirect or even better redirect to a language based on something else like browser language or something else that could help us make a best guess about what language the user might want (fallback being English with a toast(?) that explains the page isn't available in their desired language) |
Add fallback redirect to /en/ [Fixes #1374]
This is still an issue. My solution to add a broad redirect in netlify.toml (https://github.com/ethereum/ethereum-org-website/pull/1536/files) hit this issue: netlify/cli#1299 (additional files, not just HTML files, we're redirecting immediately instead of falling back to redirect if resource was not found). |
Once we roll out every page for every language (#2072), we'll be able to solve this via the |
Is your feature request related to a problem? Please describe.
Requests to pages without a language path (e.g. https://ethereum.org/eth2) currently 404.
I imagine it's easy to forget the language path when linking to pages. I myself just did this (& I build the darn site):
Describe the solution you'd like
Describe alternatives you've considered
Additional context
I tried the automatic route using our intl plugin but it lead to this issue: #1347
Note: this approach may become a valid solution again once we roll out every page for every language!
Docs on redirects using netlify.toml: https://docs.netlify.com/configure-builds/file-based-configuration/#redirects
The text was updated successfully, but these errors were encountered: