Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Translation: Add Hungarian (v1.1) #1447

Closed
samajammin opened this issue Sep 16, 2020 · 8 comments · Fixed by #1449
Closed

Site Translation: Add Hungarian (v1.1) #1447

samajammin opened this issue Sep 16, 2020 · 8 comments · Fixed by #1449
Labels
content 🖋️ This involves copy additions or edits feature ✨ This is enhancing something existing or creating something new translation 🌍 This is related to our Translation Program

Comments

@samajammin
Copy link
Contributor

samajammin commented Sep 16, 2020

Prize Bounty

40 DAI

Challenge Description

Hungarian translations have completed review & are ready to be added to the website!

Submission Requirements

  1. Download the files from CrowdIn for this version of the content (Contents v.1.1) - here's a screenshot showing how. You may need to sign up for Crowdin & join our project in order to download the files - here's the invite link.

  2. Create new directory: /src/content/translations/hu/

  3. Copy in the v1.1 Crowdin files:

  • Copy all files into the /src/content/translations/hu/ directory, keeping the same directory structure as CrowdIn (i.e. each page is a subdirectory with an index.md filename, a strings.json at the translation root & an index.md at the root of the directory)
  • Copy the strings.json file into the /src/intl/ directory & rename it to hu.json (i.e. /src/intl/hu.json), replacing the existing file
  • Delete the root index.md file (i.e. /src/content/translations/hu/index.md)
    • Beforehand: within the index.md file, move the title value & og:description's content property into the hu.json file from the previous step. Use the keys "page-home-meta-title" & "page-home-meta-description" as keys for these values. (See en.json as an example for how this should look)
  • Delete the /build/ directory (i.e. /src/content/translations/hu/build/)
    • Beforehand: within the index.md file of /build/, move the title value & og:description's content property into the hu.json file from the previous step. Use the keys "page-build-meta-title" & "page-build-meta-description" as keys for these values. (See en.json as an example for how this should look)
  1. Within each newly added markdown file...
  • Ensure each file is valid markdown (sometimes Crowdin throws in some wacky HTML elements, like a <br> or a <em>, that breaks the site build)
  • Update the frontmatter:
    • Update the lang property (it should be hu)
    • Remove any og:title or og:description properties - replace those contents with title & description field names
    • Update all sidebar fields from auto to true
    • Increase all sidebarDepth fields by 1 (e.g. 0 --> 1 & 1 --> 2)
    • (It might help to use this commit as a reference)
  1. Add an object to the languageMetadata object within /src/utils/translations.js:
hu: {
    version: 1.1,
    language: "Magyar",
    "language-english": "Hungarian",
  },

Additional context

For further guidance, see #1223 as a recent translation addition.

@samajammin samajammin added feature ✨ This is enhancing something existing or creating something new content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Sep 16, 2020
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 40.0 DAI (40.0 USD @ $1.0/DAI) attached to it as part of the ethereum fund.

@sebastiantf
Copy link
Contributor

@samajammin I have a PR up at #1454 that passes all checks

@gitcoinbot
Copy link

gitcoinbot commented Sep 21, 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 266 years, 1 month from now.
Please review their action plans below:

1) sebastiantf has been approved to start work.

I can complete this ASAP. I have prior experience with this
2) aranhaagency has been approved to start work.

I already have experience in adding translations, I would love to work on this issue too.
3) twenty1pi has applied to start work (Funders only: approve worker | reject worker).

The task is pretty straightforward and I will complete this asap

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@sebastiantf Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@sebastiantf Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@sebastiantf due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@sebastiantf due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 40.0 DAI (40.0 USD @ $1.0/DAI) has been submitted by:


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits feature ✨ This is enhancing something existing or creating something new translation 🌍 This is related to our Translation Program
Projects
None yet
3 participants