Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Hungarian (v1.1) #1449

Merged
merged 1 commit into from Sep 22, 2020
Merged

feat: Add Hungarian (v1.1) #1449

merged 1 commit into from Sep 22, 2020

Conversation

aranhaagency
Copy link
Contributor

Description

Hungarian version v1.1 translation has been added

Related Issue

close #1447

@github-actions github-actions bot added needs review 👀 Review is needed for this issue or pull request content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Sep 16, 2020
@aranhaagency aranhaagency force-pushed the Add-Hungarian branch 3 times, most recently from 72d610d to 8890113 Compare September 16, 2020 18:42
@samajammin
Copy link
Contributor

@aranhaagency thank you for this PR! I'm going to accept this & pay you the bounty but a couple notes:

  1. You should not have submitted a PR before getting approval to work on this bounty. Gitcoin has changed the way they provide bounties & as a result, there's no longer a way for us to run bounties like we have in the past (accepting the 1st to complete the PR, regardless of applying for a bounty). You should only work on a bounty if you have applied to work on the bounty & have received approval to do so. If you submit a PR again without approval, I won't pay out the bounty.

  2. The build is currently breaking, because you forgot a lang: hu in the frontmatter of one of the project files. Please always check to ensure you're build is working correctly before you submit work for a bounty. I'm going to accept it this time given it's a small fix but moving forward I will reject PRs that have failing builds.

@samajammin samajammin merged commit 1f7f633 into ethereum:dev Sep 22, 2020
This was referenced Sep 22, 2020
Closed
Closed
@samajammin
Copy link
Contributor

@aranhaagency please submit your work via Gitcoin in order to receive the bounty: https://gitcoin.co/issue/ethereum/ethereum-org-website/1447/100023708

This was referenced Sep 22, 2020
Merged
Merged
@samajammin
Copy link
Contributor

@aranhaagency see comment above.

@aranhaagency
Copy link
Contributor Author

@aranhaagency see comment above.

I did, sorry for the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits needs review 👀 Review is needed for this issue or pull request translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Site Translation: Add Hungarian (v1.1)
2 participants
@aranhaagency @samajammin