Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning messages on upgrade pages cut off #1772

Closed
ryancreatescopy opened this issue Nov 11, 2020 · 2 comments
Closed

Warning messages on upgrade pages cut off #1772

ryancreatescopy opened this issue Nov 11, 2020 · 2 comments
Labels
bug 🐛 Something isn't working high priority This has a high priority

Comments

@ryancreatescopy
Copy link
Contributor

ryancreatescopy commented Nov 11, 2020

Describe the bug

On the Eth2 upgrade pages, the warning message about scammers does not have sufficient top padding/margin on mobile. So appears cut off by the Eth2 staking banner.

To Reproduce
Steps to reproduce the behavior:

  1. Go to /eth2/beacon-chain/ /eth2/shard-chains/ or /eth2/docking/
  2. See banner

Expected behavior

There should be greater padding so you can see the whole banner. As a nice-to-have you should be able to dismiss the banner and we remember this preference in local storage.

Screenshots

image

@ryancreatescopy ryancreatescopy added the bug 🐛 Something isn't working label Nov 11, 2020
@ryancreatescopy ryancreatescopy mentioned this issue Nov 11, 2020
7 tasks
@ryancreatescopy
Copy link
Contributor Author

This issue was not fixed in the latest deploy

@wackerow
Copy link
Member

image
(Brave on left, Safari on right)

I'm gettin strange results when reproducing this. Brave on desktop displays it fine, even if you shrink the size to mobile. Brave on iOS renders incorrectly, as does Safari on both iOS and desktop.

image
(Brave on left, Safari on right)

The dev tools in Safari show that the margin is correct on , but the content does not seem to be obeying this. Not sure why this is, but thought I'd share what I noticed so far.

ryancreatescopy added a commit that referenced this issue Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working high priority This has a high priority
Projects
None yet
Development

No branches or pull requests

2 participants