Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dapps page missing descriptions #2210

Closed
samajammin opened this issue Jan 5, 2021 · 0 comments
Closed

Dapps page missing descriptions #2210

samajammin opened this issue Jan 5, 2021 · 0 comments
Labels
bug 🐛 Something isn't working

Comments

@samajammin
Copy link
Contributor

Describe the bug

To Reproduce
Steps to reproduce the behavior:

  1. Go to ethereum.org/en/dapps
  2. See error in "Lending and borrowing" as well as "Trading and prediction markets" sections:

Image 2021-01-05 at 11 30 46 AM

Expected behavior

Descriptions should show, not the translation id.

Additional context

Probably a regression of our translations rollout #2048 #2129
@samajammin samajammin added the bug 🐛 Something isn't working label Jan 5, 2021
@samajammin samajammin mentioned this issue Jan 5, 2021
Merged
samajammin added a commit that referenced this issue Jan 5, 2021
@samajammin
Merge pull request #2211 from ethereum/dapp-translation-fix
89ef478 
Translate dapp descriptions [Fixes #2210]
@samajammin samajammin mentioned this issue Jan 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samajammin