Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All CardList components now have bottom margin #6228

Closed
samajammin opened this issue May 5, 2022 · 1 comment · Fixed by #6310
Closed

All CardList components now have bottom margin #6228

samajammin opened this issue May 5, 2022 · 1 comment · Fixed by #6310
Assignees
Labels
bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help

Comments

@samajammin
Copy link
Contributor

Describe the bug

All CardLists now have a bottom margin, which I don't believe is intended. The background color is the same despite the borders:

e.g. on https://ethereum.org/en/get-eth/#country-picker
Screen Shot 2022-05-05 at 3 55 15 PM

To Reproduce
Steps to reproduce the behavior:

See example link above.

Expected behavior

I don't think we should have a margin here...

This is what those CardLists use to look like:
Screen Shot 2022-05-05 at 3 59 26 PM

Screenshots

See above.

Desktop (please complete the following information):

All

Smartphone (please complete the following information):

All

Additional context

Looks like it came from this commit?
746f3e1

I suspect @corwintines was only trying to apply this to the staking resource links:
Screen Shot 2022-05-05 at 3 56 45 PM
Which I do think look better separated by margins but we should apply to only that instance vs. across the app.

@samajammin samajammin added the bug 🐛 Something isn't working label May 5, 2022
@minimalsm minimalsm added help wanted Extra attention is needed or someone is needed to help good first issue Good item to try if you're new to contributing labels May 5, 2022
@wackerow wackerow self-assigned this May 12, 2022
@corwintines
Copy link
Member

😬

wackerow added a commit that referenced this issue May 12, 2022
corwintines added a commit that referenced this issue May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants