Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"View in English" link leading to same intl page #6318

Closed
wackerow opened this issue May 13, 2022 · 1 comment
Closed

"View in English" link leading to same intl page #6318

wackerow opened this issue May 13, 2022 · 1 comment
Labels
bug 🐛 Something isn't working Status: In Progress Work is in progress Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@wackerow
Copy link
Member

Describe the bug
Link to "View in English" on pages not yet fully up-to-date with translations is not linking to the English version, but back to the same page.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://ethereum.org/fr/developers/ or https://ethereum.org/ro/developers/ for example
  2. See button "Voir l'anglais" ("View in English")
  3. Hover and notice link to same page, and click to confirm this does not route to english page.

Expected behavior
"View in english" link on pages not up to date yet with translations should link to the /en/ path, not the selected locale.

Screenshots
image

Want to contribute?

We love contributions from the Ethereum community! Please comment on an issue if you're interested in helping out with a PR.
@wackerow wackerow added the bug 🐛 Something isn't working label May 13, 2022
@hursittarcan hursittarcan mentioned this issue May 16, 2022
Merged
@minimalsm minimalsm added the Status: In Progress Work is in progress label May 16, 2022
minimalsm added a commit that referenced this issue May 16, 2022
@minimalsm
Merge pull request #6344 from HursitTarcan/devhursit05
d260a67 
'View in English' Button Link Fixed [Solves #6318]
@corwintines corwintines mentioned this issue May 17, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working Status: In Progress Work is in progress Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wackerow @minimalsm