Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(StakingConsiderations): migrate to Chakra #10203

Merged
merged 2 commits into from May 17, 2023
Merged

refactor(StakingConsiderations): migrate to Chakra #10203

merged 2 commits into from May 17, 2023

Conversation

TylerAPfledderer
Copy link
Contributor

Description

Migrate StakingConsiderations component to Chakra.

  • Splits all logic into a separate hook
  • Create reusable child component for the indicator blocks
  • Add comment to encourage improvements in a11y for future PR

Related Issue

Part of 2nd wave of the UI Migration #8632

@github-actions github-actions bot added the needs review 👀 Review is needed for this issue or pull request label May 13, 2023
@gatsby-cloud
Copy link

gatsby-cloud bot commented May 13, 2023 •
edited

✅ ethereum-org-website-dev deploy preview ready

pettinarip
pettinarip approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @TylerAPfledderer 👍🏼 thanks

src/components/Staking/StakingConsiderations/index.tsx Outdated Show resolved Hide resolved
@pettinarip pettinarip mentioned this pull request May 17, 2023
Closed
58 tasks
@pettinarip pettinarip merged commit e93a499 into ethereum:dev May 17, 2023
3 checks passed
@TylerAPfledderer TylerAPfledderer deleted the refactor/staking-considerations-to-chakra branch May 17, 2023 22:17
@corwintines corwintines mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pettinarip pettinarip pettinarip approved these changes

@samajammin samajammin Awaiting requested review from samajammin

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

@nhsz nhsz Awaiting requested review from nhsz nhsz is a code owner

Assignees
No one assigned
Labels
chakra-migration needs review 👀 Review is needed for this issue or pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TylerAPfledderer @pettinarip