isLangRightToLeft function not using language config setting #10259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corwintines
requested review from
samajammin,
wackerow,
pettinarip,
minimalsm,
jmcook1186 and
nhsz
as code owners
github-actions
bot
added
the
needs review 👀
✅ ethereum-org-website-dev deploy preview ready
|
wackerow
requested changes
May 19, 2023
There was a problem hiding this comment.
@corwintines Pretty sure our build error is related to using the hrefLang instead of the code property... in the case of Filipino we'd be looking for fil but this doesn't exist and would result in the array being empty, and [0] wouldn't work.
src/utils/translations.ts
Outdated
| return lang === "ar" || lang === "fa" | ||
| const langConfig = i18nConfigs.filter( | ||
| (language) => language.hrefLang === lang | ||
| ) |
There was a problem hiding this comment.
We may also want to guard (or throw an error) against the case where our filtered array is empty (no matches)
Maybe:
if (!langConfig.length) throw new Error("Language code not found")or
if (!langConfig.length) return "rtl"There was a problem hiding this comment.
I think ill do the first one with throwing an error. Think this would make it easier to debug as this would be an issue. Thanks for the suggestion
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
wackerow
approved these changes
May 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
isLangRightToLeftfunction to use a languages config for lang direction instead of being hardcoded values for langauges.Related Issue
Fixes #10258