Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docsearch:description meta tag #10261

Merged
merged 1 commit into from May 19, 2023
Merged

Add docsearch:description meta tag #10261

merged 1 commit into from May 19, 2023

Conversation

wackerow
Copy link
Member

Description

@github-actions github-actions bot added the needs review 👀 Review is needed for this issue or pull request label May 19, 2023
@corwintines corwintines merged commit 5bd70ae into dev May 19, 2023
4 of 7 checks passed
@corwintines corwintines deleted the docsearch-description branch May 19, 2023 03:53
@wackerow
Copy link
Member Author

This is in attempt to bring the new DocSearch index crawler config closer to what we currently have on the site, which utilizes the metadata description.
Currently:

    "lvl2": {
      "selector": "//meta[@name='description']/@content",
      "type": "xpath",
      "global": true
    },

...but the new crawler does not support that selector syntax.

@corwintines corwintines mentioned this pull request May 19, 2023
@pettinarip
Copy link
Member

Nice @wackerow!

I was wondering if we should also add the pathname as a top level selector. For example, when you search "Get ETH" (which is the name of the page in the nav dropdown), that name does not appear in the h1 or title of that page, ignoring it from the top search results you get.

Just an idea. A different workaround could be to do something like what we are doing in the Stablecoins page where we set the same name on the h1 as in the nav's dropdown name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review 👀 Review is needed for this issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants