Update Lido trustless indicator #10416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all withdrawal credentials reportedly updated to 0x01
wackerow
requested review from
samajammin,
corwintines,
pettinarip,
minimalsm,
jmcook1186 and
nhsz
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
|
Hey @wackerow thank you for the PR reflecting the change! Just a small nit with regards to the context: rotating credentials prior to Shapella was not possible. Once Shapella went live the credentials were rotated ASAP and the results of it were evidenced and announced on twitter: https://twitter.com/LidoFinance/status/1646977448410480643 |
|
Yes 100%, pretty sure the only differentiator was some that came later we're able to default to 0x01 from the start. Glad to hear this got handled smoothly! |
corwintines
approved these changes
Jun 13, 2023
This was referenced Jun 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IIRC, the Lido "Trustless" indicator was marked false due to
0x00withdrawal credentials that had not been updated. This has reportedly been completed now (cc: @isidorosp), with request to update field value. PR flips theisTrustlessboolean for Lido totrueNote, ongoing discussion in #6452 regarding potentially redefining that category, but this PR does not address anything related to changing the definition.
Related Issue
Reported on Discord