New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update oracles page #10741
Merged
Merged
Update oracles page #10741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostly stylistic edits; in general trying to make sentences punchier and easier to read. A few disambiguating header changes as well
setgree
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm,
jmcook1186 and
nhsz
as code owners
July 20, 2023 14:19
github-actions
bot
added
content 🖋️
This involves copy additions or edits
needs review 👀
Review is needed for this issue or pull request
labels
Jul 20, 2023
✅ ethereum-org-website-dev deploy preview ready
|
minimalsm
reviewed
Jul 20, 2023
minimalsm
reviewed
Jul 20, 2023
eliminate word Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com>
looks good to me! Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com>
wackerow
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @setgree! This looks good and think it will improve the readability of the content
This was referenced Sep 27, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content 🖋️
This involves copy additions or edits
needs review 👀
Review is needed for this issue or pull request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL,DR mostly stylistic edits, trying to make sentences punchier and easier to read. A few disambiguating header changes as well.
Nce page! Read through it today and I think we can do some work to get it more in line with the Ethereum style guide, e.g. "Use active voice and clear, concise sentences that are easy to follow." Tried to implement this to the best of my ability, feel free to discard changes you don't like. THanks!