Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oracles page #10741

Merged
merged 4 commits into from Sep 21, 2023
Merged

Update oracles page #10741

merged 4 commits into from Sep 21, 2023

Conversation

setgree
Copy link
Contributor

@setgree setgree commented Jul 20, 2023

TL,DR mostly stylistic edits, trying to make sentences punchier and easier to read. A few disambiguating header changes as well.

Nce page! Read through it today and I think we can do some work to get it more in line with the Ethereum style guide, e.g. "Use active voice and clear, concise sentences that are easy to follow." Tried to implement this to the best of my ability, feel free to discard changes you don't like. THanks!

mostly stylistic edits; in general trying to make sentences punchier and easier to read. A few disambiguating header changes as well
@github-actions github-actions bot added content 🖋️ This involves copy additions or edits needs review 👀 Review is needed for this issue or pull request labels Jul 20, 2023
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 20, 2023

✅ ethereum-org-website-dev deploy preview ready

setgree and others added 2 commits July 20, 2023 12:57
eliminate word

Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com>
looks good to me!

Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com>
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @setgree! This looks good and think it will improve the readability of the content

src/content/developers/docs/oracles/index.md Outdated Show resolved Hide resolved
src/content/developers/docs/oracles/index.md Outdated Show resolved Hide resolved
@wackerow wackerow changed the title Update index.md Update oracles page Sep 21, 2023
@wackerow wackerow merged commit 6a97933 into ethereum:dev Sep 21, 2023
2 of 3 checks passed
This was referenced Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits needs review 👀 Review is needed for this issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants