Update patricia-merkle-trie/index.md #11344
Conversation
This edit improves the introduction to the Merkle-Patricia trie article, and removes a questionable claim about the 'efficiency' of lookups/writes.
gichiba
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm,
jmcook1186 and
nhsz
as code owners
github-actions
bot
added
content 🖋️
✅ ethereum-org-website-dev deploy preview ready
|
|
hey @wackerow could you sense check this smol change? |
|
As an update, the ef website now does link to the merkle tree article on ethereum.org |
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Thanks @gichiba! Overall like the updates
@minimalsm would love your take on new sentence structure here
re**trie**val is a nice touch, but wondering if this will cause difficulties with translations? cc: @lukassim
Any chance we could have the
src/content/developers/docs/data-structures-and-encoding/patricia-merkle-trie/index.md
Outdated
Show resolved
Hide resolved
This edit improves the introduction to the Merkle-Patricia trie article, and removes a questionable claim about the 'efficiency' of lookups/writes.
|
Hey @wackerow sorry I let this sit for so long; was on a long holiday leave but back in the chair! I have re-based this branch and updated the proposed changes based on your comments above! |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
This edit improves the introduction to the Merkle-Patricia trie article.
Description
The EF website may soon link to this page, so an introductory paragraph pitched more to a 'general audience' was needed to give curious individuals a softer landing, so to speak.
Also, the previous version's introduction made a claim about the 'efficiency' of inserts, lookups, and deletes, as well as a comparison to a data structure not used in Ethereum, which doesn't seem relevant for an introduction. The claim is a bit misleading, as the more compact trie structure chosen for protocol efficiency has actually created a bigger headache for execution client implementations -- better to just focus on the more straightforward description of the trie itself and leave discussions of efficiency for another article.