Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed paddings of what is etherium page [Fixes #11361] #11364

Conversation

oleksandr-hyriavets
Copy link
Contributor

Description

  • Added extra margin for a header image
  • Moved card to separate component
  • Reduces x-axis padding for a section with cards

Related Issue

#11361

@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 4, 2023

✅ ethereum-org-website-dev deploy preview ready

@konopkja
Copy link
Contributor

@konopkja
Copy link
Contributor

can u fix that in this PR too?

@TylerAPfledderer
Copy link
Contributor

Hey @konopkja! Addressed the learn page padding in #11132 per @nloureiro request.

@corwintines corwintines self-assigned this Feb 12, 2024
Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 699615c
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65cab983b1a0c20008d73b79
😎 Deploy Preview https://deploy-preview-11364--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @oleksandr-hyriavets!

We brought in a few PR's that fixed this, but wanted to credit you still for this PR :)

@corwintines corwintines merged commit 0d5cb32 into ethereum:dev Feb 13, 2024
2 checks passed
Copy link

gitpoap-bot bot commented Feb 13, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@corwintines
Copy link
Member

@all-contributors can you add @oleksandr-hyriavets for code

Copy link
Contributor

@corwintines

I've put up a pull request to add @oleksandr-hyriavets! 🎉

This was referenced Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants