-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #1149 #1161
Fixed #1149 #1161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thanks for knocking this out!
src/components/MeetupList.js
Outdated
@@ -246,6 +246,8 @@ const Table = styled.div` | |||
` | |||
|
|||
const Item = styled(Link)` | |||
flex-direction: row; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, by default any element that is display: flex
is also flex-direction: row
, so this is not necessary.
This looks great @ryancreatescopy! I added a couple minor changes & will merge. FYI, I don't think the mobile styles are strong: But they're still an improvement vs. current mobile styles: So I'm going to merge these as-is. Perhaps as a future improvement we break out the location text on a new line. |
@all-contributors please add @ryancreatescopy for code. |
I've put up a pull request to add @ryancreatescopy! 🎉 |
Agreed, ideally on mobile that description area wraps to sit under the meetup name. This becomes more problematic for the more general component where they may already be two lines of copy. Let's discuss! |
Fixed styling issues on the community meet-up card list to restore it to it's pre-Gatsby look-and-feel.
Related Issue
#1149
Screenshots (if appropriate):