Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1149 #1161

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Fixed #1149 #1161

merged 2 commits into from
Jul 7, 2020

Conversation

ryancreatescopy
Copy link
Contributor

Fixed styling issues on the community meet-up card list to restore it to it's pre-Gatsby look-and-feel.

Related Issue

#1149

Screenshots (if appropriate):

image

Fixed styling issues on the community meetup card list
Copy link
Contributor

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks for knocking this out!

@@ -246,6 +246,8 @@ const Table = styled.div`
`

const Item = styled(Link)`
flex-direction: row;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, by default any element that is display: flex is also flex-direction: row, so this is not necessary.

@samajammin
Copy link
Contributor

This looks great @ryancreatescopy! I added a couple minor changes & will merge.

FYI, I don't think the mobile styles are strong:
Image 2020-07-06 at 5 37 55 PM

But they're still an improvement vs. current mobile styles:
Image 2020-07-06 at 5 38 09 PM

So I'm going to merge these as-is. Perhaps as a future improvement we break out the location text on a new line.

@samajammin samajammin merged commit 3c35726 into dev Jul 7, 2020
@samajammin samajammin deleted the rc-1149 branch July 7, 2020 00:41
@samajammin
Copy link
Contributor

@all-contributors please add @ryancreatescopy for code.

@allcontributors
Copy link
Contributor

@samajammin

I've put up a pull request to add @ryancreatescopy! 🎉

@samajammin samajammin mentioned this pull request Jul 7, 2020
@ryancreatescopy
Copy link
Contributor Author

Agreed, ideally on mobile that description area wraps to sit under the meetup name. This becomes more problematic for the more general component where they may already be two lines of copy. Let's discuss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants