chore: fixed list shuffles on RandomAppList #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samajammin
requested changes
Jul 6, 2020
There was a problem hiding this comment.
@developerfred thanks for taking a swing at this!
Looking at the preview deploy however, the issue persists:
As mentioned in the issue, please make sure it works upon building the app, not just in your local environment. Thanks!
|
@samajammin I believe I discovered the problem, we need to use hooks. Every time the component is shuffled the Intl loads. Putting the component to be the last one to load using userEffects. makes the component work normally. |
samajammin
reviewed
Jul 7, 2020
samajammin
reviewed
Jul 7, 2020
samajammin
approved these changes
Jul 7, 2020
|
Nice! Thanks @samajammin |
|
@all-contributors please add @developerfred for code. |
|
I've put up a pull request to add @developerfred! 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing the logic of random numbers for correction or random reproduction
#1040
Related Issue
Screenshots (if appropriate):
https://share.getcloudapp.com/2Nu5prrO