Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: padding of "What can Ethereum do?" section #11687

Merged
merged 6 commits into from
Feb 12, 2024

Conversation

snowden-fu
Copy link
Contributor

@snowden-fu snowden-fu commented Nov 18, 2023

Fix: the section boundaries of "What can Ethereum do" are not aligned with others

Description

There is one more <Section> tag under <Section> as a child, so <Section> children style is duplicated twice as parent.

Solution: Replace <Section> child with simple <Box>.
Result: the edge of "What can Ethereum do" align others.
image

Related Issue

fixes #11361

Copy link

netlify bot commented Nov 18, 2023

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit b6d4bf7
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65caa2c71616900008aa2eaa
😎 Deploy Preview https://deploy-preview-11687--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Nov 18, 2023
@snowden-fu snowden-fu changed the title fix padding of "What can Ethereum do?" section Fix: padding of "What can Ethereum do?" section Nov 18, 2023
@snowden-fu
Copy link
Contributor Author

@wackerow

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @snowden-fu

@corwintines corwintines merged commit 06bbd24 into ethereum:dev Feb 12, 2024
6 checks passed
Copy link

gitpoap-bot bot commented Feb 12, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

This was referenced Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong paddings on What is ethereum page (mobile)
2 participants