Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections to Implementation Code in Dagger-Hashimoto Algorithm Documentation #11826

Merged
merged 26 commits into from
Apr 1, 2024

Conversation

joaolago1113
Copy link
Contributor

I have undertaken a series of important corrections in the implementation code of the Dagger-Hashimoto algorithm, as documented across various language translations. These modifications are crucial for maintaining the accuracy and functionality of the algorithm as represented in the documentation. Here is a brief overview of the changes made:

Commits Included:

  1. Corrections in orig_hashimoto Function:
    • Modified txid_max to txid_mix in the orig_hashimoto function across multiple language translations (PT-BR, ZH, FR, IT, TR, JA, ES, EN).
  2. Variable Name Corrections in get_prevhash Function:
    • Corrected the variable name from num to n in the get_prevhash function across multiple language translations (PT-BR, ZH, FR, IT, TR, JA, ES, EN).

These changes are not merely cosmetic but are essential for the correct representation and understanding of the Dagger-Hashimoto algorithm. They ensure that the implementation code provided in the documentation is both accurate and functional, reflecting the intended behavior of the algorithm.

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 566eb97
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65e5bc1893c6030008ea3761
😎 Deploy Preview https://deploy-preview-11826--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 translation 🌍 This is related to our Translation Program labels Dec 19, 2023
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jmcook1186 is going to do a quick review also :)

@minimalsm
Copy link
Contributor

@joaolago1113 could you merge dev again? There are conflicts and I don't have permissions to resolve

@corwintines corwintines merged commit 7a84300 into ethereum:dev Apr 1, 2024
6 checks passed
Copy link

gitpoap-bot bot commented Apr 1, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

This was referenced Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants