Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Show/Hide component usage in layouts #11903

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Conversation

wackerow
Copy link
Member

⚠️ Note: Builds on Next.js -> Do not merge until Next.js fork has been fully merged

Description

Usage of Chakra-UI Show and Hide components causing layout shifting when a page loads, since these components are built on the server where the width of the display is not yet known.

  • Updates usage within all "layout" components to use hideBelow and/or hideFrom, removing usage of Hide and Show
  • Added these directly to the shared components as their usage for mobile vs desktop does not change

corwintines and others added 3 commits January 9, 2024 12:02
Release candidate v8.0.0
For MobileButton component, removing usage of Hide/Show
For MoreContent component, removing usage of Show component
Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 28a429f
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/659ef24dc862180009b0977f
😎 Deploy Preview https://deploy-preview-11903--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@corwintines corwintines merged commit 9c9e832 into dev Jan 11, 2024
9 of 10 checks passed
@corwintines corwintines deleted the nx-rm-show-hide branch January 11, 2024 20:03
Copy link

gitpoap-bot bot commented Jan 11, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@MALIKSHAHID786
Copy link

Pending payments

This was referenced Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants