Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MeetupList.tsx to open links in new tabs [Fixes #11902] #11908

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

kamuik16
Copy link
Contributor

@kamuik16 kamuik16 commented Jan 11, 2024

Fixes #11902

Description

Added the isExternal prop to the LinkOverlay component.

Related Issue

This pull request addresses the issue described in Issue #11902

Related issue link: #11902

Copy link

netlify bot commented Jan 11, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 0d34c42
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65a003e07a8d46000807cf74
😎 Deploy Preview https://deploy-preview-11908--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@TylerAPfledderer TylerAPfledderer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thanks for addressing this bug. :)

src/components/MeetupList.tsx Outdated Show resolved Hide resolved
Co-authored-by: Tyler Pfledderer <tyler.pfledderer@gmail.com>
@kamuik16
Copy link
Contributor Author

Hi there! Thanks for addressing this bug. :)

Hey @TylerAPfledderer, I have committed the suggestions! Thanks!

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @kamuik16 and @TylerAPfledderer

@corwintines
Copy link
Member

@all-contributors can you add @kamuik16 for code

Copy link
Contributor

@corwintines

I've put up a pull request to add @kamuik16! 🎉

@corwintines corwintines merged commit e7b9117 into ethereum:dev Jan 11, 2024
6 checks passed
Copy link

gitpoap-bot bot commented Jan 11, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@kamuik16 kamuik16 deleted the kamuik16/issue11902 branch January 12, 2024 05:49
This was referenced Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ethereum meetups open in same tab
3 participants