Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated env var usage #11923

Merged
merged 1 commit into from
Jan 15, 2024
Merged

chore: remove deprecated env var usage #11923

merged 1 commit into from
Jan 15, 2024

Conversation

wackerow
Copy link
Member

Description

  • Removes NEXT_PUBLIC_SITE_URL env var now that Next.js migration is complete.
  • Replaces usage with SITE_URL constant which is set to https://ethereum.org

Related Issue

https://www.notion.so/efdn/Remove-NEXT_PUBLIC_SITE_URL-46c6bc7923de425ea50dcafe53b4e0cf?pvs=4

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit e8c86f4
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65a19a3ec1eb710008df8b27
😎 Deploy Preview https://deploy-preview-11923--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nhsz nhsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhsz nhsz merged commit 9611231 into dev Jan 15, 2024
8 of 10 checks passed
@nhsz nhsz deleted the rm-next-public-site-url branch January 15, 2024 18:01
This was referenced Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants