Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub contributors history #11990

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Fix GitHub contributors history #11990

merged 2 commits into from
Jan 23, 2024

Conversation

pettinarip
Copy link
Member

Description

Fetches the file history from the old content directory (src/content) + the new content directory (public/content) and combine both to display the full history.

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 4daba77
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65ae679a670a2900080177ef
😎 Deploy Preview https://deploy-preview-11990--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added review needed 👀 tooling 🔧 Changes related to tooling of the project labels Jan 19, 2024
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Gj @pettinarip, didn't realize we'd be able to fetch the commit history for the files from the old path. This is functioning great on my end.

Don't think it needs to block this PR, but defining a type here to replace any would be a nice-to-have. We have others on the site to potentially clean up as well (any type), perhaps we can tackle these as a separate task.

@pettinarip
Copy link
Member Author

Awesome! Gj @pettinarip, didn't realize we'd be able to fetch the commit history for the files from the old path. This is functioning great on my end.

Don't think it needs to block this PR, but defining a type here to replace any would be a nice-to-have. We have others on the site to potentially clean up as well (any type), perhaps we can tackle these as a separate task.

Good catch! totally forgot to add that type. Adding now...

Copy link
Member

@nhsz nhsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, after the extra semicolons are removed is good to go

src/hooks/useClientSideGitHubContributors.ts Show resolved Hide resolved
src/hooks/useClientSideGitHubContributors.ts Show resolved Hide resolved
@nhsz nhsz merged commit 512b1a9 into dev Jan 23, 2024
6 checks passed
@nhsz nhsz deleted the fix-github-contributors branch January 23, 2024 17:02
This was referenced Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants