fix: rtl support for embla carousel (Slider component) #11995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wackerow
requested review from
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
github-actions
bot
added
review needed 👀
tooling 🔧
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@pettinarip Okay, I'll take a look, thanks! |
pettinarip
approved these changes
Jan 23, 2024
| export interface IProps { | ||
| children?: React.ReactNode | ||
| onSlideChange?: (slideIndex: number) => void | ||
| } | ||
|
|
||
| const Slider: React.FC<IProps> = ({ children, onSlideChange }) => { | ||
| const [emblaRef, embla] = useEmblaCarousel() | ||
| const { flipForRtl, direction } = useRtlFlip() | ||
| const [emblaRef, embla] = useEmblaCarousel({ direction }) |
corwintines
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #11905 -- DO NOT MERGE before that PR
Description
useRtlFliphook to also returnisRtlanddirectionfor convenience in niche cases where these may be needed to further adjust a component for RTL details.direction("rtl" | "ltr") touseEmblaCarousel(see embla docs)Screen.Recording.2024-01-20.at.10.49.29.mov
Related Issue