Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local fonts #11998

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Local fonts #11998

merged 2 commits into from
Jan 25, 2024

Conversation

pettinarip
Copy link
Member

Currently, our fonts are consumed from Google by using next/font/google. As these fonts are fetched at build time to then be stored and selfhosted, sometimes those fetches fail making the build to fail.

Description

Add the fonts to the repo to fetch them locally at build time instead of relying on third-party services.

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit a291f68
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65b25d5b4c19d300093d39a3
😎 Deploy Preview https://deploy-preview-11998--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added review needed 👀 tooling 🔧 Changes related to tooling of the project labels Jan 22, 2024
@pettinarip pettinarip changed the title add font files to fetch them locally at build time Local fonts Jan 22, 2024
Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, approved this but noticing some differences now.

The font spacing seems off only for the Inter font, but IBMPlexMono (used in code) is fine.

Preview deploy
Screenshot 2024-01-23 at 1 54 20 PM
Production
Screenshot 2024-01-23 at 1 54 34 PM

@wackerow
Copy link
Member

+1, noticing a slight difference in how Inter appears... mono fonts look unchanged

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, perfect match now... pulling in. Thanks @pettinarip!

@wackerow wackerow merged commit d75fd8c into dev Jan 25, 2024
6 checks passed
@wackerow wackerow deleted the selfhost-fonts branch January 25, 2024 15:40
This was referenced Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants