Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates in gas docs and history docs #12008

Merged
merged 6 commits into from
Feb 12, 2024
Merged

Conversation

Crosstons
Copy link
Contributor

Fixed #5660

This pull request addresses the content update for the issue Gas page on the Ethereum website, changes introduced by the London Upgrade and EIP-1559. The content now reflects the current state of Ethereum, providing users with up-to-date information on variable-sized blocks and the revised transaction fee mechanism. Historical details have been moved to the /history/ page, offering a more streamlined and relevant user experience.

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 174aab0
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65ca62f6ff0cd900088fb2a1
😎 Deploy Preview https://deploy-preview-12008--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Jan 24, 2024
@corwintines corwintines self-assigned this Jan 25, 2024
@minimalsm
Copy link
Contributor

Hey @Crosstons, thanks for the PR 💪 this is a long-needed change 😅

At a glance this looks good, but will defer to @wackerow on the history page

@minimalsm
Copy link
Contributor

Also, @lukassim, we'll be moving translated content from one page to another; am I right in thinking Crowdin will be able to handle this automatically?

@lukassim
Copy link
Contributor

Also, @lukassim, we'll be moving translated content from one page to another; am I right in thinking Crowdin will be able to handle this automatically?

Yes, for all intents and purposes it doesn't matter much which file a piece of text is in or what the string ID in Crowdin is, all we might need to do is manually trigger a pre-translations and we're good

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Crosstons, this is great!

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Crosstons Thanks for the help here! It's not a huge deal, but if possible I'd prefer to keep the pattern of the other entries and try to pull this content out of the expandable card and weave it into the summary copy on the /history page.

public/content/history/index.md Outdated Show resolved Hide resolved
public/content/history/index.md Outdated Show resolved Hide resolved
@Crosstons
Copy link
Contributor Author

@Crosstons Thanks for the help here! It's not a huge deal, but if possible I'd prefer to keep the pattern of the other entries and try to pull this content out of the expandable card and weave it into the summary copy on the /history page.

Well thanks for the review, and I am working on this again and just so to confirm you are expecting the whole London upgrade section in the summary copy of london section above the London EIPS Expandable card without any redundant info right?

@Crosstons
Copy link
Contributor Author

@wackerow
I have committed changes as you requested, I have pulled out the content out of the expandable card and shifted it to summary copy, also for the video I have removed the Youtube embed and switch to a link.

public/content/history/index.md Outdated Show resolved Hide resolved
public/content/history/index.md Outdated Show resolved Hide resolved
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Crosstons Thanks again!

Personally would love to see a little bit more adjusting here to fit this content into this page a little better, but this at least gets the content out of the dev docs and into a more historical context. Going to pull in and we can iterate from here, thanks!

@wackerow wackerow merged commit 00f5a23 into ethereum:dev Feb 12, 2024
5 of 6 checks passed
This was referenced Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update gas docs to post-London/EIP-1559 info only
5 participants