feat: Add new words to glossary list #12016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shiva-Sai-ssb
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
❌ Deploy Preview for ethereumorg failed.
|
github-actions
bot
added
content 🖋️
|
Hey @Shiva-Sai-ssb, thanks for the PR 💪 @konopkja is currently doing some work on the strategic vision of the glossary, so I'll let them review this 😀 |
|
Hello! These look good to me apart from on-chain which we have written a bit different definition but i will add some changes based on your suggestion |
|
@pettinarip can you merge these except for the onchain one? |
pettinarip
reviewed
Feb 26, 2024
There was a problem hiding this comment.
The PR lgtm @konopkja.
LMK if these changes to this PR are what you think and we can go ahead and merge it.
konopkja
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've included six new words and their definitions to the glossary list. The words are layer-1, liquidity, max fee per gas, merkle root, off-chain, and on-chain.