Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates in style-guide and date format #12018

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

Crosstons
Copy link
Contributor

@Crosstons Crosstons commented Jan 25, 2024

Description

This Pull Request addresses the date format inconsistency highlighted in Issue #5299. The issue pertains to the use of inconsistent date formats in markdown content on the Ethereum documentation site.

Proposed Changes:

For Markdown Content:

  • Add a note to the Ethereum Style Guide outlining the preferred date format for markdown content: "D-Mon-YYYY" (e.g., 2-Nov-2023, 11-Feb-2023).
  • Emphasize the importance of maintaining consistency in date formatting to enhance clarity and comprehension.

@wackerow

Fixes: #5299

Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 3de7fb6
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65b35244f7fe8a00080ef916
😎 Deploy Preview https://deploy-preview-12018--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Jan 25, 2024
@Crosstons
Copy link
Contributor Author

@corwintines @wackerow can I expect a review for this PR?

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks @Crosstons!

@wackerow wackerow merged commit 96a6d73 into ethereum:dev Feb 12, 2024
6 checks passed
This was referenced Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add date formats to the style guide
2 participants