fix(contributors): create shape for allTimeData json type #12037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerAPfledderer
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
review needed 👀
tooling 🔧
pettinarip
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently in the
Contributorspage, there is a flatmap using theallTimeDatajson to create a simplified array of translator infotranslatorData.A type error currently throws:
Property 'data' does not exist on type '{}'This is because a type is not being inferred for the json file and is only providing an empty object.
This PR creates the shape for this data structure so there is type safety in the flatmap.
The shape was generated using Transform Web Converter App and double-checked for any undefined fields with the data used.
According to the shape generated, there should be no fields in the JSON structure that would be undefined or null.
Related Issue
N/A