Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed POAP logo render #12069

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fixed POAP logo render #12069

merged 1 commit into from
Feb 1, 2024

Conversation

vedantabanerjee
Copy link
Contributor

@vedantabanerjee vedantabanerjee commented Jan 31, 2024

The POAP logo path was wrong, upon going through the files, I figured out the right path and changed it.

Description:

Changed the poap-logo.svg path from "src/assets/poap-logo.svg" to "public/poap-logo.svg"
Screenshot 2024-01-31 at 3 11 51 PM

Issue:

Issue - "Missing Images in README.md File #12068"
Link - #12068

Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit badeb45
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65ba15f338f3e70008b7f5e8
😎 Deploy Preview https://deploy-preview-12069--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corwintines
Copy link
Member

@all-contributors can you add @vedantabanerjee for content

@corwintines corwintines merged commit ebf5f86 into ethereum:dev Feb 1, 2024
6 checks passed
Copy link

gitpoap-bot bot commented Feb 1, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

This was referenced Feb 14, 2024
@wackerow wackerow added documentation 📖 Change or add documentation and removed documentation 📖 labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Change or add documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants