Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dev docs prev and next link #12083

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

yigittopm
Copy link
Contributor

@yigittopm yigittopm commented Feb 1, 2024

Description

I rechecked the 2 values captured with the indexOf method according to their lengths and the error was solved.

I changed the > 0 query that causes skipping the first page when showing the previous page.

Related Issue

Fixes #12080

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 18adf5c
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65bc86f46854be00081f814a
😎 Deploy Preview https://deploy-preview-12083--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nhsz nhsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix! Small suggestion to keep consistency in how we're handling the indexes

src/components/DocsNav.tsx Outdated Show resolved Hide resolved
@yigittopm yigittopm requested a review from nhsz February 2, 2024 07:32
Copy link
Member

@nhsz nhsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nhsz nhsz merged commit fec8acd into ethereum:dev Feb 2, 2024
6 checks passed
Copy link

gitpoap-bot bot commented Feb 2, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

This was referenced Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Previous & Next Button in Developer Documentation shows wrong link
2 participants