Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add further reading [Fixes #11699] #12094

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

Maxservais
Copy link
Contributor

@Maxservais Maxservais commented Feb 2, 2024

Description

Added a new resource to the 'Further Reading' section on the Ethereum NFT page, providing a comprehensive list of popular NFT DApps & Tools on the Ethereum network. This enhances the page by offering direct access to practical examples and applications of NFTs.

Related Issue

Summary by CodeRabbit

  • Documentation
    • Added a link to "Popular NFT Apps and Tools" across various sections and translations of the NFT documentation, enhancing resource accessibility for users.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit b94c424
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66226a7838864e0008f4c369
😎 Deploy Preview https://deploy-preview-12094--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Feb 2, 2024
@Maxservais
Copy link
Contributor Author

@wackerow could I get your feedback on this PR when you can spare some time? Thanks a lot!

Copy link
Contributor

coderabbitai bot commented Mar 11, 2024

Walkthrough

These updates involve adding a link to "Popular NFT Apps and Tools" across various sections of the content, specifically within the NFT security section and the NFT index pages. The changes are applied not only to the primary content but also to translations in Filipino, Nigerian Pidgin, and Turkish, ensuring that the resource becomes accessible to a broader audience.

Changes

File Path Change Summary
public/content/nft/index.md Added link to "Popular NFT Apps and Tools" in NFT security section and index page.
public/content/.../fil/nft/index.md Added link to "Popular NFT Apps and Tools" in NFT index page.
public/content/.../pcm/nft/index.md Added link to "Popular NFT Apps and Tools" in NFT security section.
public/content/.../tr/nft/index.md Added link to "Popular NFT Apps and Tools" in NFT index page.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Maxservais
Copy link
Contributor Author

I changed from "dapps" to "apps" following @konopkja's thoughful feedback: #11699 (comment)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 6afb437 and a52fd54.
Files selected for processing (4)
  • public/content/nft/index.md (1 hunks)
  • public/content/translations/fil/nft/index.md (1 hunks)
  • public/content/translations/pcm/nft/index.md (1 hunks)
  • public/content/translations/tr/nft/index.md (1 hunks)
Additional comments: 4
public/content/translations/pcm/nft/index.md (1)
  • 91-91: The addition of the link to "Popular NFT Apps and Tools" in the Further Reading section is a valuable resource for readers interested in exploring NFT DApps & Tools on the Ethereum network. This aligns well with the PR's objective to enhance the Ethereum NFT page by providing practical examples and applications of NFTs.
public/content/nft/index.md (1)
  • 99-99: The addition of the link to "Popular NFT Apps and Tools" in the Further Reading section is a valuable resource for readers interested in exploring NFT DApps & Tools on the Ethereum network. This aligns well with the PR's objective to enrich the content of the page with valuable resources for further exploration. However, it's important to ensure that the linked content is maintained and updated regularly to keep it relevant and useful for the audience.
public/content/translations/tr/nft/index.md (1)
  • 99-99: The addition of the link to "Popular NFT Apps and Tools" under the 'Further Reading' section is a valuable resource for users interested in exploring NFT applications and tools further. Ensure the link is relevant, accessible, and safe for users.
public/content/translations/fil/nft/index.md (1)
  • 91-91: The addition of the link to "Popular NFT Apps and Tools" enriches the content by providing readers with direct access to practical examples and applications of NFTs on the Ethereum network. This aligns with the PR's objective to enhance the Ethereum NFT page with valuable resources for further exploration.

However, it's essential to ensure that the link is accessible and leads to a reputable source that is maintained and updated regularly to remain relevant and useful for readers.

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Maxservais! Looks good, just not sure about adding this to the non-English pages with the English label... Typically we would add this to the English page only, and then it would be uploaded to Crowdin for translation... is there a reason these are added for fil, pcm and tr here?

@Maxservais
Copy link
Contributor Author

Hey @wackerow, really sorry, it was a mistake.
I have removed the text from the translated files!

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Maxservais!

@wackerow wackerow merged commit cfc2026 into ethereum:dev May 7, 2024
6 checks passed
This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants