-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add further reading [Fixes #11699] #12094
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@wackerow could I get your feedback on this PR when you can spare some time? Thanks a lot! |
WalkthroughThese updates involve adding a link to "Popular NFT Apps and Tools" across various sections of the content, specifically within the NFT security section and the NFT index pages. The changes are applied not only to the primary content but also to translations in Filipino, Nigerian Pidgin, and Turkish, ensuring that the resource becomes accessible to a broader audience. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
I changed from "dapps" to "apps" following @konopkja's thoughful feedback: #11699 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (4)
- public/content/nft/index.md (1 hunks)
- public/content/translations/fil/nft/index.md (1 hunks)
- public/content/translations/pcm/nft/index.md (1 hunks)
- public/content/translations/tr/nft/index.md (1 hunks)
Additional comments: 4
public/content/translations/pcm/nft/index.md (1)
- 91-91: The addition of the link to "Popular NFT Apps and Tools" in the Further Reading section is a valuable resource for readers interested in exploring NFT DApps & Tools on the Ethereum network. This aligns well with the PR's objective to enhance the Ethereum NFT page by providing practical examples and applications of NFTs.
public/content/nft/index.md (1)
- 99-99: The addition of the link to "Popular NFT Apps and Tools" in the Further Reading section is a valuable resource for readers interested in exploring NFT DApps & Tools on the Ethereum network. This aligns well with the PR's objective to enrich the content of the page with valuable resources for further exploration. However, it's important to ensure that the linked content is maintained and updated regularly to keep it relevant and useful for the audience.
public/content/translations/tr/nft/index.md (1)
- 99-99: The addition of the link to "Popular NFT Apps and Tools" under the 'Further Reading' section is a valuable resource for users interested in exploring NFT applications and tools further. Ensure the link is relevant, accessible, and safe for users.
public/content/translations/fil/nft/index.md (1)
- 91-91: The addition of the link to "Popular NFT Apps and Tools" enriches the content by providing readers with direct access to practical examples and applications of NFTs on the Ethereum network. This aligns with the PR's objective to enhance the Ethereum NFT page with valuable resources for further exploration.
However, it's essential to ensure that the link is accessible and leads to a reputable source that is maintained and updated regularly to remain relevant and useful for readers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Maxservais! Looks good, just not sure about adding this to the non-English pages with the English label... Typically we would add this to the English page only, and then it would be uploaded to Crowdin for translation... is there a reason these are added for fil
, pcm
and tr
here?
Hey @wackerow, really sorry, it was a mistake. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Maxservais!
Description
Added a new resource to the 'Further Reading' section on the Ethereum NFT page, providing a comprehensive list of popular NFT DApps & Tools on the Ethereum network. This enhances the page by offering direct access to practical examples and applications of NFTs.
Related Issue
Summary by CodeRabbit