Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table overflow #12128

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Fix table overflow #12128

merged 2 commits into from
Feb 16, 2024

Conversation

pettinarip
Copy link
Member

@pettinarip pettinarip commented Feb 7, 2024

Description

Adds relative position to the table container to avoid overflows.

Related Issue

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit dcb61d1
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65cc749767e37b0008734b87
😎 Deploy Preview https://deploy-preview-12128--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TylerAPfledderer
Copy link
Contributor

@pettinarip it still does not seem to be fixed 🤔
Screenshot_20240207-230407.png

@pettinarip
Copy link
Member Author

@TylerAPfledderer thanks for testing. Could you double-check it? using incognito could be better, just to avoid any potential cache.

I tested this on ios (safari and chrome), linux & win (chrome & brave) and it is working fine. LMK what OS and browser you are testing.

@TylerAPfledderer
Copy link
Contributor

@TylerAPfledderer thanks for testing. Could you double-check it? using incognito could be better, just to avoid any potential cache.

I tested this on ios (safari and chrome), linux & win (chrome & brave) and it is working fine. LMK what OS and browser you are testing.

So what I showed above is from Chrome on Android 14. Also breaking similarly in:

  • Firefox Android 14 (Incognito)
  • Chrome Android 14 (Incognito)
  • Brave Windows OS (normal and private window)

@pettinarip
Copy link
Member Author

@TylerAPfledderer tested it using BrowserStack and it worked fine in a Samsung Galaxy S24, android 14, Chrome & FF.

image

Its weird. I've also tested it in my personal android phone and worked too. Perhaps it is the browser version? 🤔 Im using Chrome v121.0.6167.164

@wackerow
Copy link
Member

@pettinarip Yeah, I am seeing the same thing as @TylerAPfledderer... both on iOS (Brave and Safari), and Android (Chrome... technically Vanadium)... and also when mocking mobile sizes using a desktop browser.

The horizontal scroll only goes away if I remove the table entirely, otherwise it's definitely persisting for me.

@pettinarip
Copy link
Member Author

@wackerow wow, this is even weirder haha

I've tested it on my personal phone (android), on a physical iphone, on different laptops, and they all work fine for me! what is going on! xD

Are we all using the correct preview deploy? it is https://deploy-preview-12128--ethereumorg.netlify.app/developers/docs/evm/opcodes

@TylerAPfledderer
Copy link
Contributor

@wackerow wow, this is even weirder haha

I've tested it on my personal phone (android), on a physical iphone, on different laptops, and they all work fine for me! what is going on! xD

Are we all using the correct preview deploy? it is https://deploy-preview-12128--ethereumorg.netlify.app/developers/docs/evm/opcodes

@pettinarip actually look at this page:
https://deploy-preview-12128--ethereumorg.netlify.app/energy-consumption

@wackerow
Copy link
Member

Yeah, +1 to @TylerAPfledderer... @pettinarip I am not having issues with the opcodes page, but I am getting horizontal scroll on the energy consumption page (caused by the table)

@pettinarip
Copy link
Member Author

Aha! @TylerAPfledderer @wackerow I missed that case! 🙃 for some reason I always thought you were testing the opcodes page haha...my bad.

Ok! I've set a width to one of the containers that were used in the Static layout and that should fix the issue.

@TylerAPfledderer
Copy link
Contributor

Aha! @TylerAPfledderer @wackerow I missed that case! 🙃 for some reason I always thought you were testing the opcodes page haha...my bad.

Ok! I've set a width to one of the containers that were used in the Static layout and that should fix the issue.

Good with me!

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed for me now :)

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! Thanks @pettinarip!

@wackerow wackerow merged commit 3b3835c into dev Feb 16, 2024
6 of 7 checks passed
@wackerow wackerow deleted the fix-table-overflow branch February 16, 2024 01:48
This was referenced Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The table is too large for small screens Opcode table horizontal scrolling
4 participants