Added missing whitespace after numbered emojis in all languages [Fixe… #12179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RabihJabr29
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
corwintines
requested changes
Feb 14, 2024
There was a problem hiding this comment.
Thanks @RabihJabr29!
Ive left some suggestions which I think will be a cleaner solution. Instead of using margins, we can use the the character code for a space instead to get this. HTML is removing the white spaces between the Emoji and text, but if we add this character code it will be included.
| @@ -12,31 +12,31 @@ Ultimately, this is a great way to build a diverse and impressive portfolio that | |||
|
|
|||
| ## How to contribute? | |||
|
|
|||
| ### <Emoji text=":one:" size={1} /> Provide feedback on early design prototypes {#design-critique} | |||
| ### <Emoji text=":one:" size={1} me="2" /> Provide feedback on early design prototypes {#design-critique} | |||
There was a problem hiding this comment.
Suggested change
| ### <Emoji text=":one:" size={1} me="2" /> Provide feedback on early design prototypes {#design-critique} | |
| ### <Emoji text=":one:" size={1} /> Provide feedback on early design prototypes {#design-critique} |
|
|
||
| We sometimes need a help testing our raw ideas. This is a great way how to contribute without any technical knowledge. | ||
|
|
||
| 1. The design team will share a mockup design on [Discord](https://discord.com/invite/ethereum-org) and on [GitHub](https://github.com/ethereum/ethereum-org-website/labels/design%20required%20%F0%9F%8E%A8). | ||
| 2. You will be guided through the designs to provide feedback via comments function. | ||
| 3. The outcome will be shared in the GitHub issue and then closed by the team. | ||
|
|
||
| ### <Emoji text=":two:" size={1} /> Participate in survey research {#answer-surveys} | ||
| ### <Emoji text=":two:" size={1} me="2" /> Participate in survey research {#answer-surveys} |
There was a problem hiding this comment.
Suggested change
| ### <Emoji text=":two:" size={1} me="2" /> Participate in survey research {#answer-surveys} | |
| ### <Emoji text=":two:" size={1} /> Participate in survey research {#answer-surveys} |
|
|
||
| Provide feedback on our website by: | ||
|
|
||
| 1. Visiting ethereum.org and reading through pages. | ||
| 2. Clicking on the feedback widget at the bottom right corner and answering design and content-related questions. | ||
| 3. Focus on the free format questions. | ||
|
|
||
| ### <Emoji text=":three:" size={1} /> Find design related issues on the website and report them {#report-design-issues} | ||
| ### <Emoji text=":three:" size={1} me="2" /> Find design related issues on the website and report them {#report-design-issues} |
There was a problem hiding this comment.
Suggested change
| ### <Emoji text=":three:" size={1} me="2" /> Find design related issues on the website and report them {#report-design-issues} | |
| ### <Emoji text=":three:" size={1} /> Find design related issues on the website and report them {#report-design-issues} |
|
|
||
| Ethereum.org is a fast growing website with many features and content. Some of the UI can easily become obsolete or could be improved. If you encounter any such instance, please report it so that it gets our attention. | ||
|
|
||
| 1. Go through the website and pay attention to its design. | ||
| 2. Take screenshots and notes if you see any visual or UX issues. | ||
| 3. Report the found issues using a [bug report](https://github.com/ethereum/ethereum-org-website/issues/new/choose). | ||
|
|
||
| ### <Emoji text=":four:" size={1} /> Propose design changes {#propose-design-changes} | ||
| ### <Emoji text=":four:" size={1} me="2" /> Propose design changes {#propose-design-changes} |
There was a problem hiding this comment.
Suggested change
| ### <Emoji text=":four:" size={1} me="2" /> Propose design changes {#propose-design-changes} | |
| ### <Emoji text=":four:" size={1} /> Propose design changes {#propose-design-changes} |
| @@ -45,7 +45,7 @@ If you feel comfortable taking on design challenges, you can visit our GitHub is | |||
| 3. Propose the solution in the corresponding GitHub issue or [create a new one.](https://github.com/ethereum/ethereum-org-website/issues/new?assignees=&labels=feature+%3Asparkles%3A&template=feature_request.yaml&title=Feature+request) | |||
| 4. Wait for the design team to review. | |||
|
|
|||
| ### <Emoji text=":five:" size={1} /> Build Design System together {#Contribute-to-design-system} | |||
| ### <Emoji text=":five:" size={1} me="2" /> Build Design System together {#Contribute-to-design-system} | |||
There was a problem hiding this comment.
Suggested change
| ### <Emoji text=":five:" size={1} me="2" /> Build Design System together {#Contribute-to-design-system} | |
| ### <Emoji text=":five:" size={1} /> Build Design System together {#Contribute-to-design-system} |
|
|
||
| Web sitemiz hakkında geribildirim sağlayın: | ||
|
|
||
| 1. Ethereum.org'u ziyaret edin ve sayfaları baştan sona okuyun. | ||
| 2. Sağ alt köşede bulunan geribildirim aracına tıklayıp tasarım ve içerik ile ilgili soruları cevaplayın. | ||
| 3. Serbest biçimdeki sorulara odaklanın. | ||
|
|
||
| ### <Emoji text=":three:" size={1} /> Web sitesindeki tasarımla ilgili sorunları bulun ve bildirin {#report-design-issues} | ||
| ### <Emoji text=":three:" size={1} me="2" /> Web sitesindeki tasarımla ilgili sorunları bulun ve bildirin {#report-design-issues} |
There was a problem hiding this comment.
Suggested change
| ### <Emoji text=":three:" size={1} me="2" /> Web sitesindeki tasarımla ilgili sorunları bulun ve bildirin {#report-design-issues} | |
| ### <Emoji text=":three:" size={1} /> Web sitesindeki tasarımla ilgili sorunları bulun ve bildirin {#report-design-issues} |
|
|
||
| Ethereum.org, birçok içeriğe ve özelliğe sahip, hızla büyüyen bir web sitesidir. Bazı kullanıcı arayüzleri, kolayca güncelliğini yitirebilir ya da geliştirilebilir. Böyle bir durumla karşılaşırsanız, dikkate almamız için lütfen bize bildirin. | ||
|
|
||
| 1. Web sitesine gidin ve tasarımları dikkatle inceleyin. | ||
| 2. Herhangi bir görsel sorun ya da kullanıcı deneyimi sorunu görürseniz, ekran görüntüsü ve notlar alın. | ||
| 3. Bulduğunuz sorunları [hata raporu](https://github.com/ethereum/ethereum-org-website/issues/new/choose) ile bildirin. | ||
|
|
||
| ### <Emoji text=":four:" size={1} /> Tasarım değişiklikleri önerin {#propose-design-changes} | ||
| ### <Emoji text=":four:" size={1} me="2" /> Tasarım değişiklikleri önerin {#propose-design-changes} |
There was a problem hiding this comment.
Suggested change
| ### <Emoji text=":four:" size={1} me="2" /> Tasarım değişiklikleri önerin {#propose-design-changes} | |
| ### <Emoji text=":four:" size={1} /> Tasarım değişiklikleri önerin {#propose-design-changes} |
| @@ -45,7 +45,7 @@ Tasarım zorluklarının üstesinden gelme konusunda kendinizi rahat hissediyors | |||
| 3. İlgili GitHub konusunda çözümü önerin ya da [yeni bir tane oluşturun.](https://github.com/ethereum/ethereum-org-website/issues/new?assignees=&labels=feature+%3Asparkles%3A&template=feature_request.yaml&title=Feature+request) | |||
| 4. İncelemesi için tasarım ekibini bekleyin. | |||
|
|
|||
| ### <Emoji text=":five:" size={1} /> Tasarım Sistemini birlikte geliştirin {#Contribute-to-design-system} | |||
| ### <Emoji text=":five:" size={1} me="2" /> Tasarım Sistemini birlikte geliştirin {#Contribute-to-design-system} | |||
There was a problem hiding this comment.
Suggested change
| ### <Emoji text=":five:" size={1} me="2" /> Tasarım Sistemini birlikte geliştirin {#Contribute-to-design-system} | |
| ### <Emoji text=":five:" size={1} /> Tasarım Sistemini birlikte geliştirin {#Contribute-to-design-system} |
| @@ -56,7 +56,7 @@ Tasarım sistemimiz, ethereum.org'u tasarlamayı eğlenceli ve kolay hale getiri | |||
| 5. Tasarım ekibi inceleyecektir. | |||
| 6. Tasarım ekibi, değişiklikleri ana dosyada toplayacak ve bu dosyayı topluluk ile paylaşacaktır. | |||
|
|
|||
| ### <Emoji text=":six:" size={1} /> Web sitesinde tasarımla ilgili içerik yazın {#write-design-articles} | |||
| ### <Emoji text=":six:" size={1} me="2" /> Web sitesinde tasarımla ilgili içerik yazın {#write-design-articles} | |||
There was a problem hiding this comment.
Suggested change
| ### <Emoji text=":six:" size={1} me="2" /> Web sitesinde tasarımla ilgili içerik yazın {#write-design-articles} | |
| ### <Emoji text=":six:" size={1} /> Web sitesinde tasarımla ilgili içerik yazın {#write-design-articles} |
| @@ -66,7 +66,7 @@ Ethereum geliştirici topluluğu güçlü olsa da, tasarım topluluğu biraz dah | |||
| 4. Onaylandıktan sonra içeriği yazın. | |||
| 5. İlgili GH konusunda sunun. | |||
|
|
|||
| ### <Emoji text=":seven:" size={1} /> Yeni illüstrasyonlar çizin {#prepare-illustrations} | |||
| ### <Emoji text=":seven:" size={1} me="2" /> Yeni illüstrasyonlar çizin {#prepare-illustrations} | |||
There was a problem hiding this comment.
Suggested change
| ### <Emoji text=":seven:" size={1} me="2" /> Yeni illüstrasyonlar çizin {#prepare-illustrations} | |
| ### <Emoji text=":seven:" size={1} /> Yeni illüstrasyonlar çizin {#prepare-illustrations} |
|
Hello again, @corwintines |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2024 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s #12173]
Added missing whitespace after numbered emojis in all languages [Fixes #12173 ]
Description
Issue #12173
Missing space between emoji and text on design page
Added the missing whitespace by having the property me="2" in the "Emoji" elements.
Done for all languages.