Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up translation for Ethereum in numbers on /what-is-ethereum [Fixes #11726] #12214

Merged
merged 3 commits into from
May 7, 2024

Conversation

fragtex-eth
Copy link
Contributor

@fragtex-eth fragtex-eth commented Feb 17, 2024

Description

  • Set up missing translations for the "Ethereum in numbers" section on the /what-is-ethereum page

Related Issue

Copy link

netlify bot commented Feb 17, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit c80b557
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65d11b3787cc660008877775
😎 Deploy Preview https://deploy-preview-12214--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 translation 🌍 This is related to our Translation Program labels Feb 17, 2024
@fragtex-eth fragtex-eth changed the title Added translation for Ethereum in numbers on /what-is-ethereum [Fixes #11726] Set up translation for Ethereum in numbers on /what-is-ethereum [Fixes #11726] Feb 17, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Stale label May 7, 2024
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice job @fragtex-eth! Sorry for delay here, but this looks good. Appreciate your thoroughness with internationalizing the number formatting as well. 🎉

"page-what-is-ethereum-ethereum-in-numbers-stat-2-desc": "Accounts (wallets) with an ETH balance",
"page-what-is-ethereum-ethereum-in-numbers-stat-3-desc": "Smart contracts on Ethereum",
"page-what-is-ethereum-ethereum-in-numbers-stat-4-desc": "Value secured on Ethereum",
"page-what-is-ethereum-ethereum-in-numbers-stat-5-desc": "Creator earnings on Ethereum in 2021",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, 2021... side note, we need to update this

<NoWrapText>
today{" "}
&nbsp;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@wackerow wackerow merged commit 1c76eb0 into ethereum:dev May 7, 2024
6 checks passed
Copy link

gitpoap-bot bot commented May 7, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Ethereum in numbers for translation on /what-is-ethereum
2 participants