Hide contributor's profile link if the url doesn't exist #12272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pettinarip
requested review from
wackerow,
corwintines,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wackerow
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Nice, this lgtm...
Tried testing on a few pages including
- https://deploy-preview-12272--ethereumorg.netlify.app/ka/developers/docs/consensus-mechanisms/pos/keys/
- (Compare to) https://ethereum.org/ka/developers/docs/consensus-mechanisms/pos/keys
Only question I have here... should we consider any case where there is a user.login but no user.url? In that case we could potentially just render the name without a link... don't think that needs to block this PR though.
nhsz
approved these changes
Feb 22, 2024
minimalsm
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hides the contributor's profile link if the url doesn't exist.
Related Issue
Fixes #12269