Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add matomo event to lang picker input #12276

Merged
merged 2 commits into from
Feb 25, 2024
Merged

feat: add matomo event to lang picker input #12276

merged 2 commits into from
Feb 25, 2024

Conversation

wackerow
Copy link
Member

Description

  • Add matomo event when user focuses in language picker filter input
  • De-duped to only send one event per session, per language (resets if user follows a language result and switches languages)

cc: @konopkja

@netlify Netlify
Copy link

netlify bot commented Feb 22, 2024 •
edited

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit ca4f2bd
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65d7e13becea200008396dc9
😎 Deploy Preview https://deploy-preview-12276--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nhsz
nhsz approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@nhsz nhsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhsz nhsz merged commit 8e95063 into dev Feb 25, 2024
9 of 10 checks passed
@nhsz nhsz deleted the matomo-lang-picker branch February 25, 2024 21:11
This was referenced Feb 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhsz nhsz nhsz approved these changes

@konopkja konopkja konopkja approved these changes

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wackerow @nhsz @konopkja