Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nav item hover zone, opening delay duration #12380

Merged
merged 2 commits into from
Mar 6, 2024
Merged

fix: nav item hover zone, opening delay duration #12380

merged 2 commits into from
Mar 6, 2024

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Mar 5, 2024

Description

  • Removes delay duration when hovering over a nav menu item (menu now opens immediately upon hovering)
  • Extends the click/hover zone for each button to the bottom of the nav bar, eliminating dead-space between the buttons and the menu that opens which could close the menu if cursor is paused in this space

Related Issue

Bug surfaced from #12125 review

cc: @konopkja

@github-actions github-actions bot added review needed 👀 tooling 🔧 Changes related to tooling of the project labels Mar 5, 2024
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 48ee6c7
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65e7c50267a8870009b960cf
😎 Deploy Preview https://deploy-preview-12380--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Use pseudo-element within button element to fill dead-space below button, preventing menu closure when mouse pauses in this space (while maintaining original button size)
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! interesting solution, LGTM!

@konopkja
Copy link
Contributor

konopkja commented Mar 6, 2024

LGTM! i think this will improve the current experience! nice job

Copy link
Member

@nhsz nhsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhsz nhsz merged commit 45ef0d9 into dev Mar 6, 2024
10 checks passed
@nhsz nhsz deleted the nav-delay branch March 6, 2024 12:48
This was referenced Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants