-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix translation typos #12388
Fix translation typos #12388
Conversation
WalkthroughThis update focuses on refining the translations for the Danksharding section across Spanish, French, Italian, and Brazilian Portuguese versions of the Ethereum website. It corrects technical inaccuracies, grammatical errors, and clarifies concepts related to Ethereum scaling, rollups, and the proposer-builder separation in Danksharding. The aim is to enhance the understanding and accuracy of these complex topics for non-English speakers. Changes
Related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (4)
- public/content/translations/es/roadmap/danksharding/index.md (2 hunks)
- public/content/translations/fr/roadmap/danksharding/index.md (1 hunks)
- public/content/translations/it/roadmap/danksharding/index.md (2 hunks)
- public/content/translations/pt-br/roadmap/danksharding/index.md (1 hunks)
Files skipped from review due to trivial changes (1)
- public/content/translations/pt-br/roadmap/danksharding/index.md
Additional comments: 5
public/content/translations/it/roadmap/danksharding/index.md (3)
- 22-22: In the explanation about how rollups make transactions cheaper, the text is clear and correctly explains the concept. However, it's important to ensure that the technical terms used are consistent with those in the original English version and commonly accepted translations in the Italian Ethereum community.
- 28-28: The section explaining why it's okay to delete blob data accurately conveys the concept of data availability and the temporary nature of blob storage in the context of rollups. This is crucial for understanding the efficiency improvements brought by Proto-Danksharding.
- 52-52: The explanation regarding the necessity of keeping KZG random data secret is technically accurate and important for understanding the security implications of the KZG ceremony. It's essential that this explanation remains clear and accurate to prevent misunderstandings about the cryptographic processes involved.
public/content/translations/es/roadmap/danksharding/index.md (1)
- 68-68: The explanation of why Danksharding requires proposer-builder separation is crucial for understanding the architectural changes necessary for scaling Ethereum. It's important that this section accurately conveys the rationale behind these changes to ensure readers grasp the significance of the separation for decentralization and efficiency.
public/content/translations/fr/roadmap/danksharding/index.md (1)
- 18-18: The correction made in the description of the Proto-Danksharding concept appears to accurately address the grammatical error and enhances the clarity of the explanation regarding the cost reduction for rollups facilitated by data blobs. This change aligns with the PR's objectives and improves the document's overall readability and accuracy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fix some translation errors/typos identified by coderabbitai in another PR
Related Issue
Identified in #12385
Summary by CodeRabbit