Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation typos #12388

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fix translation typos #12388

merged 1 commit into from
Mar 7, 2024

Conversation

minimalsm
Copy link
Contributor

@minimalsm minimalsm commented Mar 6, 2024

Description

Fix some translation errors/typos identified by coderabbitai in another PR

Related Issue

Identified in #12385

Summary by CodeRabbit

  • Documentation
    • Updated Spanish translations in the Danksharding roadmap to clarify Ethereum scaling concepts.
    • Corrected grammatical error in French Danksharding roadmap, emphasizing cost reduction for rollups.
    • Improved Italian translations for Danksharding roadmap by fixing typographical errors and enhancing text clarity.
    • Fixed a typo in the Portuguese (Brazil) Danksharding roadmap related to data blobs.

Copy link
Contributor

coderabbitai bot commented Mar 6, 2024

Walkthrough

This update focuses on refining the translations for the Danksharding section across Spanish, French, Italian, and Brazilian Portuguese versions of the Ethereum website. It corrects technical inaccuracies, grammatical errors, and clarifies concepts related to Ethereum scaling, rollups, and the proposer-builder separation in Danksharding. The aim is to enhance the understanding and accuracy of these complex topics for non-English speakers.

Changes

File Path Change Summary
.../es/roadmap/danksharding/index.md Corrections in Spanish translations for Ethereum scaling concepts and Danksharding details.
.../fr/roadmap/danksharding/index.md Corrected a grammatical error and emphasized cost reduction for rollups in French translation.
.../it/roadmap/danksharding/index.md Improved clarity and corrected typographical errors in Italian translation.
.../pt-br/roadmap/danksharding/index.md Corrected a typo related to "blobs" in Brazilian Portuguese translation.

Related issues

  • ethereum/ethereum-org-website#12097: This issue could be linked to the PR as it discusses enabling translations for various elements on the Ethereum website, which aligns with the PR's goal of improving translations for better localization and inclusivity. The PR's work on refining translations directly contributes to making the website more accessible to non-English speakers, addressing one of the key objectives of the issue.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions github-actions bot added the content 🖋️ This involves copy additions or edits label Mar 6, 2024
Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit d107e3c
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65e8905a8e1ffd0008407155
😎 Deploy Preview https://deploy-preview-12388--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between bda9262 and d107e3c.
Files selected for processing (4)
  • public/content/translations/es/roadmap/danksharding/index.md (2 hunks)
  • public/content/translations/fr/roadmap/danksharding/index.md (1 hunks)
  • public/content/translations/it/roadmap/danksharding/index.md (2 hunks)
  • public/content/translations/pt-br/roadmap/danksharding/index.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • public/content/translations/pt-br/roadmap/danksharding/index.md
Additional comments: 5
public/content/translations/it/roadmap/danksharding/index.md (3)
  • 22-22: In the explanation about how rollups make transactions cheaper, the text is clear and correctly explains the concept. However, it's important to ensure that the technical terms used are consistent with those in the original English version and commonly accepted translations in the Italian Ethereum community.
  • 28-28: The section explaining why it's okay to delete blob data accurately conveys the concept of data availability and the temporary nature of blob storage in the context of rollups. This is crucial for understanding the efficiency improvements brought by Proto-Danksharding.
  • 52-52: The explanation regarding the necessity of keeping KZG random data secret is technically accurate and important for understanding the security implications of the KZG ceremony. It's essential that this explanation remains clear and accurate to prevent misunderstandings about the cryptographic processes involved.
public/content/translations/es/roadmap/danksharding/index.md (1)
  • 68-68: The explanation of why Danksharding requires proposer-builder separation is crucial for understanding the architectural changes necessary for scaling Ethereum. It's important that this section accurately conveys the rationale behind these changes to ensure readers grasp the significance of the separation for decentralization and efficiency.
public/content/translations/fr/roadmap/danksharding/index.md (1)
  • 18-18: The correction made in the description of the Proto-Danksharding concept appears to accurately address the grammatical error and enhances the clarity of the explanation regarding the cost reduction for rollups facilitated by data blobs. This change aligns with the PR's objectives and improves the document's overall readability and accuracy.

Copy link
Member

@nhsz nhsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhsz nhsz merged commit 7b17ba5 into dev Mar 7, 2024
6 checks passed
@nhsz nhsz deleted the fixTranslationTypos branch March 7, 2024 00:05
This was referenced Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants