Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETH Rio changed to May #12404

Merged
merged 1 commit into from
Mar 8, 2024
Merged

ETH Rio changed to May #12404

merged 1 commit into from
Mar 8, 2024

Conversation

nloureiro
Copy link
Contributor

@nloureiro nloureiro commented Mar 8, 2024

ETH Rio was scheduled to March and changed to May

Summary by CodeRabbit

  • Chores
    • Updated the community events list by removing outdated conference information and adding new details for the "ETH Rio" conference.

Copy link
Contributor

coderabbitai bot commented Mar 8, 2024

Walkthrough

The update involves adjusting the conference information within the community events data. Specifically, it removes the entry for the "Ethereum Rio" conference and introduces a new entry for "ETH Rio," complete with revised dates, a fresh description, and an updated URL. This modification ensures the event details are current and accurately represented, reflecting the latest information about the conference.

Changes

File Change Summary
src/data/community-events.ts Removed "Ethereum Rio" and added "ETH Rio" with new details.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 84b93e1
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/65eaf8440fc6730008e663ae
😎 Deploy Preview https://deploy-preview-12404--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nloureiro nloureiro linked an issue Mar 8, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7607a7a and 84b93e1.
Files selected for processing (1)
  • src/data/community-events.ts (2 hunks)
Additional comments: 1
src/data/community-events.ts (1)
  • 214-222: The addition of the "ETH Rio" event with updated details, including the new dates, URL, and description, correctly aligns with the PR objectives. However, there are a few points to consider for improvement:
  • Ensure consistency in date formatting. The startDate and endDate for "ETH Rio" use the format "YYYY-MM-DD", which is good practice for consistency and sorting. It's recommended to audit the entire file to ensure all events follow this format, as some entries use "YYYY-M-D" without leading zeros.
  • Consider adding validation or a comment regarding the format and expectations for each field to improve maintainability and ensure future contributions adhere to the same standards.

Overall, the changes meet the objectives and follow best practices for data structure and clarity. Just ensure consistency across the entire file for date formats and possibly add comments for field expectations.

Copy link
Member

@nhsz nhsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nhsz nhsz merged commit a91a532 into dev Mar 8, 2024
6 checks passed
@nhsz nhsz deleted the ETH-Rio-is-back branch March 8, 2024 14:04
This was referenced Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event listing
2 participants