Fix typos in glossary terms #12430
Fix typos in glossary terms #12430
Conversation
pettinarip
requested review from
wackerow,
corwintines,
minimalsm and
nhsz
as code owners
WalkthroughThe overall change addresses the correction of hyperlinks in various language translations of a document related to energy consumption. These modifications specifically target the correction of links that reference a 51% attack scenario within the context of Ethereum's proof-of-stake (PoS) consensus mechanism. The aim is to ensure that these references are accurate and direct users to the correct information regarding potential attack vulnerabilities in Ethereum's blockchain security. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
content 🖋️
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (5)
src/intl/en/glossary-tooltip.jsonis excluded by:!**/*.jsonsrc/intl/en/glossary.jsonis excluded by:!**/*.jsonsrc/intl/fr/glossary.jsonis excluded by:!**/*.jsonsrc/intl/hu/glossary.jsonis excluded by:!**/*.jsonsrc/intl/it/glossary.jsonis excluded by:!**/*.json
Files selected for processing (4)
- public/content/translations/ca/energy-consumption/index.md (1 hunks)
- public/content/translations/id/energy-consumption/index.md (1 hunks)
- public/content/translations/nl/energy-consumption/index.md (1 hunks)
- public/content/translations/ro/energy-consumption/index.md (1 hunks)
Additional comments: 6
public/content/translations/id/energy-consumption/index.md (2)
- 27-27: The correction of the hyperlink related to a 51% attack in the context of Ethereum's proof of stake (PoS) consensus mechanism is crucial for ensuring that readers have access to accurate and reliable information. This change helps maintain the integrity and accuracy of the document, especially in discussions about security vulnerabilities and consensus mechanisms in blockchain technology.
- 24-30: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-103]
Overall, the document provides a clear and comprehensive overview of Ethereum's energy consumption, with a focus on the transition from proof of work (PoW) to proof of stake (PoS). The translation appears to be accurate and maintains the integrity of the original content. It's important to ensure that such documents remain up-to-date and continue to reflect the latest developments in Ethereum's roadmap and consensus mechanisms.
public/content/translations/nl/energy-consumption/index.md (2)
- 27-27: The correction of the hyperlink related to a 51% attack in the context of Ethereum's proof of stake (PoS) versus proof of work (PoW) is crucial for ensuring that readers have access to accurate and reliable information. This change helps maintain the integrity and accuracy of the document, especially in discussions about security vulnerabilities and consensus mechanisms in blockchain technology.
- 24-30: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-103]
Overall, the document provides a clear and comprehensive overview of Ethereum's energy consumption, with a focus on the transition from proof of work (PoW) to proof of stake (PoS). The translation appears to be accurate and maintains the integrity of the original content. It's important to ensure that such documents remain up-to-date and continue to reflect the latest developments in Ethereum's roadmap and consensus mechanisms.
public/content/translations/ro/energy-consumption/index.md (1)
- 27-27: The update to the hyperlink for the "51% attack" glossary term is accurate and aligns with the PR's objectives to ensure correct redirection and information access. This correction is crucial for maintaining the integrity of the document, especially given its focus on Ethereum's consensus mechanisms and energy consumption.
However, it's recommended to conduct a thorough review of the entire document to ensure all terminology and hyperlinks are consistent and accurate, given the document's significance in explaining critical aspects of Ethereum's operation and environmental impact.
public/content/translations/ca/energy-consumption/index.md (1)
- 27-27: The hyperlink correction to the 51% attack scenario is accurate and improves the document's reliability by ensuring readers are directed to the correct information. This change aligns with the PR's objective of updating glossary terms and correcting hyperlinks across translations. The modification is crucial for providing accurate information about potential attack scenarios in Ethereum's PoS mechanism.
| @@ -128,7 +128,7 @@ | |||
| "execution-layer-term": "Couche d'exécution", | |||
| "execution-layer-definition": "La couche d'exécution d'Ethereum est le réseau des <a href=\"/glossary/#execution-client\">clients d'exécution</a>.", | |||
| "eoa-term": "Compte externe (EOA)", | |||
| "eoa-definition": "Les comptes détenus en externe (EOA) sont des <a href=\"/glossary/#account\">comptes</a> contrôlés par des <a href=\"/glossary/#private-key\">clés privées</a>, généralement générées à l'aide d'une <a href=\"/glossary/#hd-wallet-seed\">phrase de récupération</a>. Contrairement aux contrats intelligents, les comptes détenus en externe sont des comptes auxquels aucun code n'est associé. En général, ces comptes sont gérés par un <a href=\"/glossary/#wallet\">portefeuille</a>.", | |||
| "eoa-definition": "Les comptes détenus en externe (EOA) sont des <a href=\"/glossary/#account\">comptes</a> contrôlés par des <a href=\"/glossary/#private-key\">clés privées</a>, généralement générées à l'aide d'une <a href=\"/glossary/#recovery-phrase\">phrase de récupération</a>. Contrairement aux contrats intelligents, les comptes détenus en externe sont des comptes auxquels aucun code n'est associé. En général, ces comptes sont gérés par un <a href=\"/glossary/#wallet\">portefeuille</a>.", | |||
There was a problem hiding this comment.
Was recovery-phrase added recently? I'm not finding it in the glossary
There was a problem hiding this comment.
I see recovery-phrase-term and recovery-phrase-definition in /en/glossary-tooltip.json and /en/glossary.json
Was merged last week #12236, but isnt in production yet.
Description
Fixes typos in glossary term keys and changes others that don't exist anymore.
Summary by CodeRabbit