Matched button styles to DS [Fixes #1249] #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samajammin
added
design required 🎨
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made sure button styles have appropriate hover and active states as per the design system styles. Decided to leave focus as this should be covered by the browser.
Created new theme values to do this across light and dark mode. Eventually, we may need to think more carefully about our color names in the theme as I'm not sure how sustainable having values like
SecondaryButtonHoveris and things could get messy. But thought it was important we fix accessibility issues first.Related Issue
#1249
Screenshots (if appropriate):
Best place to review would be
/buildas it has a secondary and primary button.