-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Crowdin leaderboard data fetching #12670
Conversation
❌ Deploy Preview for ethereumorg failed. Why did it fail? →
|
@lukassim If you wouldn't mind dropping an approval if you agree with the behavior described in the original post, that would help, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, we do know there's a slight discrepancy between the leaderboard and what's showing in Crowdin, since we're excluding TM matches from the leaderboard
I think that's actually for the better and it makes more sense to only show the words translated 'from scratch' on the leaderboards
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just pushed a commit up to clean up unused types (there was a TODO), and an unnecessary division
Description
.github/workflows/get-leaderboard-reports.yml
getLeaderboardReports.ts
script and posts results as PRsrc/scripts/crowdin/leaderboard/getLeaderboardReports.ts
The script was also run for this PR, so new data files are included. In the future the scripts here will run through GitHub cron jobs.
Preview links
Related issue