Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crowdin leaderboard data fetching #12670

Merged
merged 8 commits into from
Apr 30, 2024
Merged

fix: Crowdin leaderboard data fetching #12670

merged 8 commits into from
Apr 30, 2024

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Apr 5, 2024

Description

.github/workflows/get-leaderboard-reports.yml

  • Runs on first of every month to get cost reports for translation leaderboard
  • Runs getLeaderboardReports.ts script and posts results as PR

src/scripts/crowdin/leaderboard/getLeaderboardReports.ts

  • Calculates date ranges: Grabs most recent completed month, quarter and also all-time values
  • Triggers building a report using Crowdin API
  • Awaits completion then downloads report
  • Parses data for what we need before saving (utilizing the existing location for this data, but schema will be more trimmed down now)
  • Updates components that consume this data to use new data format

The script was also run for this PR, so new data files are included. In the future the scripts here will run through GitHub cron jobs.

Preview links

Related issue

@wackerow wackerow added the Status: In Progress Work is in progress label Apr 5, 2024
@github-actions github-actions bot added needs review 👀 tooling 🔧 Changes related to tooling of the project labels Apr 5, 2024
Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for ethereumorg failed. Why did it fail? →

Name Link
🔨 Latest commit 3ec8246
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6630651ac690af0008f79077

@wackerow wackerow changed the title WIP Crowdin leaderboard data fetching Crowdin leaderboard data fetching Apr 9, 2024
@wackerow wackerow marked this pull request as ready for review April 9, 2024 18:12
@wackerow wackerow changed the title Crowdin leaderboard data fetching fix: Crowdin leaderboard data fetching Apr 16, 2024
@wackerow wackerow requested a review from lukassim April 23, 2024 22:58
@wackerow
Copy link
Member Author

@lukassim If you wouldn't mind dropping an approval if you agree with the behavior described in the original post, that would help, thanks!

Copy link
Contributor

@lukassim lukassim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, we do know there's a slight discrepancy between the leaderboard and what's showing in Crowdin, since we're excluding TM matches from the leaderboard
I think that's actually for the better and it makes more sense to only show the words translated 'from scratch' on the leaderboards
LGTM

@corwintines corwintines self-assigned this Apr 30, 2024
Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just pushed a commit up to clean up unused types (there was a TODO), and an unnecessary division

@wackerow wackerow merged commit ed065cb into dev Apr 30, 2024
6 of 10 checks passed
@wackerow wackerow deleted the crowdin-leaderboard branch April 30, 2024 03:41
This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress Work is in progress tooling 🔧 Changes related to tooling of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation leaderboard is outdated
3 participants